[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#971810: marked as done (engrampa FTCBFS: AC_RUN_IFELSE)

Your message dated Fri, 29 Dec 2023 07:19:18 +0000
with message-id <E1rJ79K-0036Pw-C4@fasolo.debian.org>
and subject line Bug#971810: fixed in engrampa 1.26.1-1
has caused the Debian Bug report #971810,
regarding engrampa FTCBFS: AC_RUN_IFELSE
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
971810: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971810
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: engrampa
Version: 1.24.1-1
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

engrampa fails to cross build from source, because it uses a run check
to discover the behaviour of file wrt zstd. This has two problems:
 A) It uses AC_RUN_IFELSE, which breaks cross compilation.
 B) It checks the version of file used during build. Not the one it is
    working with.

I'm attaching a patch that makes it simply assume a recent file during
cross compilation and we can be done with that. My solution leaves
aspect B) unaddressed. Please close this bug even if not solving B).

For solving B), there are a number of options. A simple one is issuing a
runtime dependency on libmagic1 (>= 1:5.38). Then you always have the
fixed libmagic and nothing to worry about.

This doesn't work upstream however. For upstream there also is a better
solution. Instead of checking the behaviour of file at build time, you
can check the version of file at runtime. You can simply call
magic_version() in the application.

Just some thoughts. The bug is really about A).

Helmut

--- engrampa-1.24.1.orig/configure.ac
+++ engrampa-1.24.1/configure.ac
@@ -190,9 +190,15 @@
     }
     return status;]])],
 		[zstd_mime_type="application/x-zstd"],
-		[zstd_mime_type="application/zstd"]
+		[zstd_mime_type="application/zstd"],
+		[zstd_mime_type="cross"]
 	)
-	AC_MSG_RESULT($zstd_mime_type)
+	AS_IF([test "$zstd_mime_type" = "cross"],[
+		zstd_mime_type="application/x-zstd"
+		AC_MSG_RESULT(cross, guessing $zstd_mime_type)
+	],[
+		AC_MSG_RESULT($zstd_mime_type)
+	])
 	dnl *******************************************
 
 	LIBS="$save_LIBS"

--- End Message ---
--- Begin Message --- 
Source: engrampa
Source-Version: 1.26.1-1
Done: Mike Gabriel <sunweaver@debian.org>

We believe that the bug you reported is fixed in the latest version of
engrampa, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 971810@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated engrampa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 29 Dec 2023 07:24:57 +0100
Source: engrampa
Architecture: source
Version: 1.26.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian+Ubuntu MATE Packaging Team <debian-mate@lists.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 913075 971810
Changes:
 engrampa (1.26.1-1) unstable; urgency=medium
 .
   * New upstream release.
     - Fix archive 'save as' function. (Closes: #913075).
   * debian/control:
     + Bump Standards-Version: to 4.6.2. No changes needed.
   * debian/copyright:
     + Update copyright attribution for debian/.
   * debian/patches:
     + Add 2001_fix-FTCBFS.patch. Fix FTCBFS in AC_RUN_IFELSE. (Closes:
       #971810).
     + Add 1001_add-shebang-to-isoinfo-script.patch. Add missing shebang.
       Thanks, lintian.
   * debian/rules:
     + Install executables to /usr/libexec directory.
   * debian/engrampa.install:
     + Adjust to libexecdir installation path change.
Checksums-Sha1:
 f71dfeedf7e0e45e4c5982efa170d915df0d84e9 2390 engrampa_1.26.1-1.dsc
 1710f27674f762f3343abd267667d3f86101e468 1179232 engrampa_1.26.1.orig.tar.xz
 110da9826e1c0e15e96a333f87568274eec1a62c 9484 engrampa_1.26.1-1.debian.tar.xz
 f4554fb37906170614aa5ab7b8231156df2752a2 17253 engrampa_1.26.1-1_source.buildinfo
Checksums-Sha256:
 1496bbd52605b8287ca571dc9177be5f56ccfbb685164605babcc377d2701727 2390 engrampa_1.26.1-1.dsc
 6cc9ce7a803aeddcead95db32e8ebca69a7b22930710b8343432ac925dfd88fc 1179232 engrampa_1.26.1.orig.tar.xz
 071595a2cfa4a0ebcc92b05db2d7075ddcfce0ec731425dbbc25104e2aafc4e1 9484 engrampa_1.26.1-1.debian.tar.xz
 702c862e21434b3426f0991299f77f32e032523fde1a01b657b293852a25d082 17253 engrampa_1.26.1-1_source.buildinfo
Files:
 a61b90513edb6276cb2d6dd0186bb120 2390 x11 optional engrampa_1.26.1-1.dsc
 6a90bd1f2fd8c4ebb8b72a3735efa657 1179232 x11 optional engrampa_1.26.1.orig.tar.xz
 edb5e11cf268aeb8aef26cd414854a5e 9484 x11 optional engrampa_1.26.1-1.debian.tar.xz
 92b63976effc48bc1fd63ba7b27d503a 17253 x11 optional engrampa_1.26.1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmWObpkVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxT6cP/1yMvBDjXBA6TLDl5D2U9H0bVuXX
zooXYWT3mfxLS5Nqhyt44oPLH4IjnQpP0VgPE2bdomPV0g93uzC6D8qbPAXCWKkj
qFMN4dMp6u36TM0vzyh1cUtpqGFLfAgKONof9Kdn3sObp2lfMTNKjfwVyiKWukwG
naMAm/xxIHazYaWRw5oyx3DvDgdEIq0K8ZKOnURUGvi5m/vD+gsSAi2scBkQNXx+
9ShlvkoMaaPo8voFz4X8teJalqYiR9HYBxvACR0+XgXeX8MOUBFL7HANhEFcPVg7
JhK5Vp86n96zjjnzj7qwV/g+NXqFkZtnfEFM8jbAbJNn8sCnFKCsMwNWGlmK4ehK
Xpld8QfgI68/I4+2Nt15orWsNdNxxRG25iQ2YmusvwctLRokGOWAzZ8Ihv+Bkios
CFoKAPfzND6A+vKOlRWFYdtyHMCrwwsTr3F+ZUULyjAQs7L7fmdiojZwPKH0lkoT
sO7MB1OHHj2wijY3bYOsRzta9Pm4KiIEEby7GF0mZ1PCyR7cCfwx+TKSLir6oo3Z
UO8jeTWIU2dQ0nYXSuII/979UG5gAsABrO9RhdJV4qlPthz1bIp0+ow1rQv0KCVM
cbSw1ILHuUh3iHL9mcA8I7IIV+ftMiFiLihzWpN758UhDDue6rqVdm3K64u5vfvg
vxkMUu5qNtPD1ftn
=H6jM
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: