[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#951357: mate-desktop: please make the build reproducible



Source: mate-desktop
Version: 1.24.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
mate-desktop could not be built reproducibly.

This is is because it generated a "release year" based on the current
build date which was embedded in the binary. A patch attached that
uses SOURCE_DATE_EPOCH. [1]

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/docs/source-date-epoch/


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2020-02-15 09:13:42.840879272 +0000
@@ -0,0 +1,16 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2020-02-15
+
+--- mate-desktop-1.24.0.orig/configure.ac
++++ mate-desktop-1.24.0/configure.ac
+@@ -62,6 +62,9 @@ AC_DEFINE(MATE_MINOR, [mate_minor], [Def
+ AC_DEFINE(MATE_MICRO, [mate_micro], [Define to the micro version])
+ 
+ RELEASE_YEAR=`date +%Y`
++if test "x$SOURCE_DATE_EPOCH" != "x"; then
++	RELEASE_YEAR=`date -u -d "@$SOURCE_DATE_EPOCH" +%Y 2>/dev/null || date -u -r $SOURCE_DATE_EPOCH +%Y || date -u +%Y`
++fi
+ AC_SUBST([RELEASE_YEAR])
+ 
+ AC_ARG_ENABLE(deprecation_flags,
--- a/debian/patches/series	2020-02-15 09:06:22.606417590 +0000
--- b/debian/patches/series	2020-02-15 09:13:40.864798339 +0000
@@ -1 +1,2 @@
 2001_prefer-x-terminal-emulator.patch
+reproducible-build.patch

Reply to: