[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#939499: mate-tweak: Panel configuration produces TypeError due to dock absence



Hi Paul,

On  Do 05 Sep 2019 17:05:41 CEST, Paul Boddie wrote:

Package: mate-tweak
Version: 16.10.5-1+deb9u1
Severity: normal
Tags: patch

Dear Maintainer,

Running mate-tweak and attempting panel configuration, selecting different
icon sizes, repeatably causes a TypeError in the program. This does not crash
the user interface, however.

  File "/usr/bin/mate-tweak", line 912, in combo_fallback
    self.additional_tweaks(schema, key, value[1])
  File "/usr/bin/mate-tweak", line 904, in additional_tweaks
    self.replace_panel_layout(self.base_layout)
  File "/usr/bin/mate-tweak", line 748, in replace_panel_layout
    self.disable_dock()
  File "/usr/bin/mate-tweak", line 497, in disable_dock
    self.remove_dock_autostart()
  File "/usr/bin/mate-tweak", line 461, in remove_dock_autostart
if os.path.exists(os.path.join(config_dir, 'autostart/') + self.dock + '.desktop'):
TypeError: Can't convert 'NoneType' object to str implicitly

The problem is caused by an absence of any recognised dock, thus self.dock
being None, and thus the error occurs. As far as I can tell, a simple fix that
short-circuits the test is sufficient, and I can provide a trivial patch for
this purpose.

Sorry if this is already fixed, either upstream or in another version of the
package. I was investigating mate-tweak to see if I could get panel icons to
appear since they appear as dark blue rectangles for me, but that is another
problem.

can you file a pull request von Github?
https://github.com/ubuntu-mate/mate-tweak

If not, it is fine to send a patch to this bug report and I will handle the upstreaming.

Thanks,
Mike
--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpXyorF0rait.pgp
Description: Digitale PGP-Signatur


Reply to: