[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#895995: mate-themes: High contrast themes show transparent zones instead of black when rendered with metacity



Package: mate-themes
Version: 3.22.11-1
Severity: important
Tags: upstream patch
Forwarded: https://github.com/mate-desktop/mate-themes/issues/211

Hello,

As reported upstream, the background of decoration buttons of high
contrast themes show up transparent instead of black, making them
unreadable and thus unusable.  That can be seen in metacity-theme-viewer
by selecting the Metacity themes and then a high contrast theme (both
have the issue), as the attached snapshot shows.  The attached patch,
submitted upstream, fixes them.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mate-themes depends on:
ii  gtk2-engines          1:2.20.2-5
ii  gtk2-engines-murrine  0.98.2-2
ii  gtk2-engines-pixbuf   2.24.32-1
ii  librsvg2-common       2.40.20-2
ii  mate-icon-theme       1.20.0-1

Versions of packages mate-themes recommends:
ii  dmz-cursor-theme  0.4.5

mate-themes suggests no packages.

-- no debconf information

-- 
Samuel
  bien sûr que ça convient mieux à tout le monde
  enfin, dans la mesure où tout le monde c'est comme moi
 -+- le consensus, c'est facile -+-

Attachment: metacity-theme-viewer.png
Description: PNG image

Index: mate-themes-3.22.11/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml
===================================================================
--- mate-themes-3.22.11.orig/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml
+++ mate-themes-3.22.11/desktop-themes/ContrastHighInverse/metacity-1/metacity-theme-1.xml
@@ -147,7 +147,7 @@
 </draw_ops>
 
 <draw_ops name="outer_bevel">
-  <rectangle color="gtk:fg[NORMAL]"
+  <rectangle color="gtk:bg[NORMAL]" filled="true"
              x="0" y="0" width="width-1" height="height-1"/>
   <line color="gtk:light[NORMAL]"
         x1="1" y1="1" x2="1" y2="height-2"/>
Index: mate-themes-3.22.11/marco-themes/HighContrast/metacity-theme-1.xml
===================================================================
--- mate-themes-3.22.11.orig/marco-themes/HighContrast/metacity-theme-1.xml
+++ mate-themes-3.22.11/marco-themes/HighContrast/metacity-theme-1.xml
@@ -57,6 +57,7 @@
 
 <!-- define constants -->
 <constant name="ArrowSpacer" value="8"/>
+<constant name="ArrowBorder" value="2"/>
 <constant name="MinArrowSize" value="7"/>
 <constant name="ButtonIPad" value="6"/>
 <constant name="ThickLineWidth" value="3"/>
@@ -72,6 +73,9 @@
 </draw_ops>
 
 <draw_ops name="menu_button">
+  <rectangle color="gtk:bg[NORMAL]" filled="true"
+             x="ArrowBorder" y="ArrowBorder"
+             width="width-2*ArrowBorder" height="height-2*ArrowBorder"/>
   <gtk_arrow state="normal" shadow="out" arrow="down"
              x="ArrowSpacer `min` (width-MinArrowSize)/2"
              y="ArrowSpacer `min` (height-MinArrowSize)/2"
@@ -147,7 +151,7 @@
 </draw_ops>
 
 <draw_ops name="outer_bevel">
-  <rectangle color="gtk:fg[NORMAL]"
+  <rectangle color="gtk:fg[NORMAL]" filled="true"
              x="0" y="0" width="width-1" height="height-1"/>
   <line color="gtk:light[NORMAL]"
         x1="1" y1="1" x2="1" y2="height-2"/>

Reply to: