Hi Hugo, On 20/01/20 3:04 am, Hugo Lefeuvre wrote: >>> I've uploaded a snapshot of qemu 1:2.1+dfsg-12+deb8u13 to mentors.d.net. >>> The relevant .dsc could be found here[1]. >>> >>> Whilst I think it should be safe to upload, I'd still appreciate a >>> review to make sure that there's no regression. >> >> I will take a look at it in the evening. > > I did not have time to test the changes, however I have: > - reviewed the debdiff carefully > - compared with upstream changes > - checked for discrepancies in the underlying macros > - compiled and inspected the logs > > and everything looks fine to me! Thank you so much for the review! \o/ > (That being said I would definitely not > upload these changes without at least smoke testing slirp. :)) Shall do. I'll also try to get the reproducer's test file/case and shall check with that. Thank you, once again! Best, Utkarsh
Attachment:
signature.asc
Description: OpenPGP digital signature