[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: icu package and debdiff [new contributor, first attempt]

Hi Markus,

On Mon, Jun 20, 2016 at 12:43:02PM +0200, Markus Koschany wrote:
> Hello Roberto,
> > As far as upstream feedback, I presume I should post my updated patches
> > to either ticket 12020 or 12276.  Would that be the best approach? 
> Yes, that would be a good approach indeed.
> > I am not totally clear on what sort of feedback I should seek from
> > upstream.  Should I just ask for a review of the patches I have
> > prepared?  Would I do that by posting to the ticket?
> I would post to the ticket and ask for a review of your patches. All
> upstreams I have contacted so far were really helpful and of course they
> are interested that their software is properly fixed too.
> > 
> > I'd like to think that small scale and scope of the changes and the fact
> > that they are already included in upstream ICU (I think) and in OpenJDK
> > means that the changes are solid.  However, I understand that a
> > regression could be disruptive to wheezy users so I don't want to do
> > something that would unreasonably risk that occurring.  Could you (or
> > anyone else) suggest a course of action here?
> Since Antoine already made a good experience with upstream, I recommend
> to contact them by posting to the ticket or other communication channels
> (e-mail, IRC, etc.) and ask for a review of your patches. That is the
> best course of action in this case. In the unlikely case that they are
> totally hostile, you have to use your own judgment but I don't expect
> that to happen.

Thanks very much for the feedback.  I will do as you suggest and request
that upstream review the patches.



Roberto C. Sánchez

Reply to: