[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#837639: marked as done (lsb-base: get_lsb_header_val() should strip leading spaces)

Your message dated Fri, 25 Nov 2016 15:34:01 +0000
with message-id <E1cAIVl-000Ake-Hs@fasolo.debian.org>
and subject line Bug#837639: fixed in lsb 9.20161125
has caused the Debian Bug report #837639,
regarding lsb-base: get_lsb_header_val() should strip leading spaces
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
837639: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837639
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lsb-base
Version: 4.1+Debian13+nmu1
Severity: minor
Tags: patch

Dear Maintainer,

most LSB headers are indented for visual readability (table format), but
get_lsb_header_val() from /lib/lsb/init-functions does not strip leading
spaces, leading to visual anomalies when later used quoted.

IMHO all leading blanks should be stripped:

--- /lib/lsb/init-functions     2016-09-13 10:26:56.348000000 +0200
+++ init-functions      2016-09-13 10:26:53.868000000 +0200
@@ -260,7 +260,7 @@
         fi
         LSB_S="### BEGIN INIT INFO"
         LSB_E="### END INIT INFO"
-        sed -n "/$LSB_S/,/$LSB_E/ s/# $2: \(.*\)/\1/p" $1
+        sed -n "/$LSB_S/,/$LSB_E/ s/# $2: \+\(.*\)/\1/p" "$1"
 }
 
 # If the currently running init daemon is upstart, return zero; if the

The patch assumes sed does eager wildcards - I verified it does.

PS: $1 should be quoted as well to support file names containings
characters in $IFS.

-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: lsb
Source-Version: 9.20161125

We believe that the bug you reported is fixed in the latest version of
lsb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 837639@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <odyx@debian.org> (supplier of updated lsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 25 Nov 2016 16:15:24 +0100
Source: lsb
Binary: lsb-base lsb-release lsb-compat
Architecture: source
Version: 9.20161125
Distribution: unstable
Urgency: medium
Maintainer: Debian LSB Team <debian-lsb@lists.debian.org>
Changed-By: Didier Raboud <odyx@debian.org>
Description:
 lsb-base   - Linux Standard Base init script functionality
 lsb-compat - Linux Standard Base Compatibility
 lsb-release - Linux Standard Base version reporting utility
Closes: 837639 845489
Changes:
 lsb (9.20161125) unstable; urgency=medium
 .
   [ Didier Raboud ]
   * Test the distro-info non-Debian fallback, to fix #845489
   * Also run the tests for all pyversions (Python 2.7 only)
   * Fix regressions on python2 (Closes: #845489)
 .
   [ Philipp Hahn ]
   * Strip leading spaces in get_lsb_header_val (Closes: #837639)
Checksums-Sha1:
 36532d79291138c2ccc5c4c6fbdf580451aca642 1697 lsb_9.20161125.dsc
 368331f9a4c09d622510138a91d73ccd54a5540e 43096 lsb_9.20161125.tar.xz
Checksums-Sha256:
 f2dd58084b1beabe966136cfd2e1b355002c1fb1635a6db5ef159b09ed94864f 1697 lsb_9.20161125.dsc
 0f9889ff1922da54d1f1538c11a57aa21dc5adf621e6201b18026f6633088bbd 43096 lsb_9.20161125.tar.xz
Files:
 f278191a471765f167fd185993f49bff 1697 misc extra lsb_9.20161125.dsc
 a3ada3f03c7f00752c831e3afc74ca2f 43096 misc extra lsb_9.20161125.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEe+WPIRpjNw1/GSB7i8+nHsoWNFUFAlg4VhcACgkQi8+nHsoW
NFXOEgv+Kg+q42CAzyUdYrOMtMos2hUHgQWQwkAhOItVNxyQI9nX5nOEGCihJvIl
z3Fz7j2rHFyCOH2EGEKFxtZ3/rWuNNkOIMIs7SUnjQnaRcveGea/mMdENnf6zvUc
MPghMyuSNrWEk/Pu07LXwXWxHyNsWWBx7MLiBgrpq+QJaR6bER+n+QjT/a4Welg4
cly1/8b8fadcTu0Di3Mk07eH1GZvlizT1p/rCE8HtKQRyVDvWJa6u3ue5EkHUddq
JbJv0NuUkjsGB8xHflmf4ifAyqhOXLkdb1bPFM8Xze/5GngZo8h72EY98E08gz/Q
GoqHyioxIuLRu6ZRSuRhWaWzdqaCTqVx8xnckAc0LZpRKSmw3uUpx3O4OoEOuGU7
bngGhqkzytnUllg+MRD9X0zf94J9Ui6arajtzhBsIXZz6xZKvDh39wjYnz0xmgdo
LXxrThMjcSH48RX1p82+RhJ9YI4g9+Eoo+R+Rq6Tq+h4PUO5Ij8LLs+1bwlrbhCY
/rvLJUWt
=bvOU
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: