[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#837639: lsb-base: get_lsb_header_val() should strip leading spaces



Package: lsb-base
Version: 4.1+Debian13+nmu1
Severity: minor
Tags: patch

Dear Maintainer,

most LSB headers are indented for visual readability (table format), but
get_lsb_header_val() from /lib/lsb/init-functions does not strip leading
spaces, leading to visual anomalies when later used quoted.

IMHO all leading blanks should be stripped:

--- /lib/lsb/init-functions     2016-09-13 10:26:56.348000000 +0200
+++ init-functions      2016-09-13 10:26:53.868000000 +0200
@@ -260,7 +260,7 @@
         fi
         LSB_S="### BEGIN INIT INFO"
         LSB_E="### END INIT INFO"
-        sed -n "/$LSB_S/,/$LSB_E/ s/# $2: \(.*\)/\1/p" $1
+        sed -n "/$LSB_S/,/$LSB_E/ s/# $2: \+\(.*\)/\1/p" "$1"
 }
 
 # If the currently running init daemon is upstart, return zero; if the

The patch assumes sed does eager wildcards - I verified it does.

PS: $1 should be quoted as well to support file names containings
characters in $IFS.

-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- no debconf information


Reply to: