Bug#710571: Patch for /lib/lsb/init-functions
Control: severity -1 minor
Control: merge 683654 -1
Control: tag 683654 +wontfix -moreinfo
Hi Josh, hi Teodor,
Le samedi, 1 juin 2013 09.41:00, Teodor MICU a écrit :
> This topic was discussed with LSB maintainers on #683654. Maybe these
> two bugs should be merged, but I don't know if the discussion will be
> preserved.
Indeed, hereby merging.
Le samedi, 1 juin 2013 02.28:24, vous avez écrit :
> The attached git patch makes the log_* functions in
> /lib/lsb/init-functions check $VERBOSE before outputting anything.
As I wrote in #683654:
> I think that the fact that a call to log_*_msg always leads to having a
> message printed is actually a feature and a characteristic of these shell
> functions. Changing this interface to start printing messages conditionally
> is a quite intrusive change IMHO.
I have now also re-read the #683654 bugreport and got more convinced that
changing these logging functions is a really bad idea. The biggest blocker
that I see is the output that one gets when managing services by hand: if one
setups VERBOSE=no in /etc/default/rcS, then any service action (such as #
service cups restart) will log exactly no output to the console, while now you
get a useful message.
So I currently stand to my initial appreciation of this bug (hence untagging
moreinfo and tagging wontfix): it is in my (current) opinion of the daemon's
initscripts responsibility to define what messages should be logged and which
not, so the VERBOSE environment variable should be handled by these and not
globally by init-functions. As for boot splashs (or whatever software is
annoyed by init scripts' outputs), they have multiple solutions readily
available: I/O multiplexing [0] (by doing filtering, or even discarding of the
outputs of the initscripts), diversion of the lsb init functions by dropping a
file in /lib/lsb/init-functions.d/, etc.
Cheers,
OdyX
[0] http://web.dodds.net/~vorlon/wiki/blog/Plymouth_is_not_a_bootsplash/
Reply to: