[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#708337: marked as done (lsb: Please revert unnecessary use of /bin/echo -n)

Your message dated Wed, 15 May 2013 11:18:29 +0000
with message-id <E1UcZj3-0006Um-5F@franck.debian.org>
and subject line Bug#708337: fixed in lsb 4.1+Debian10
has caused the Debian Bug report #708337,
regarding lsb: Please revert unnecessary use of /bin/echo -n
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
708337: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=708337
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lsb
Version: 4.1+Debian9
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu saucy ubuntu-patch

Hi guys,

In response to bug #602038, the init-functions scripts in lsb-base have been
changed to use /bin/echo -n instead of echo -n.  This results in a lot of
added forks which are unnecessary and inappropriate: 'echo -n' is guaranteed
by Debian policy to be supported by the shell.

Please revert this change, improving the efficiency of this
boot-performance-sensitive shell library.  I've attached a patch to do this.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

=== modified file 'init-functions'
--- init-functions	2012-11-12 08:58:04 +0000
+++ init-functions	2013-05-15 07:40:53 +0000
@@ -280,7 +280,7 @@
     if [ -z "${1:-}" ]; then
         return 1
     fi
-    /bin/echo -n "$@" || true
+    echo -n "$@" || true
     log_begin_msg_post "$@"
 }
 
@@ -305,11 +305,11 @@
     log_daemon_msg_pre "$@"
 
     if [ -z "${2:-}" ]; then
-        /bin/echo -n "$1:" || true
+        echo -n "$1:" || true
         return
     fi
     
-    /bin/echo -n "$1: $2" || true
+    echo -n "$1: $2" || true
     log_daemon_msg_post "$@"
 }
 
@@ -332,7 +332,7 @@
     if [ -z "${1:-}" ]; then
         return 1
     fi
-    /bin/echo -n " $@" || true
+    echo -n " $@" || true
 }
 
 
@@ -379,12 +379,12 @@
 
 log_action_begin_msg () {
     log_action_begin_msg_pre "$@"
-    /bin/echo -n "$@..." || true
+    echo -n "$@..." || true
     log_action_begin_msg_post "$@"
 }
 
 log_action_cont_msg () {
-    /bin/echo -n "$@..." || true
+    echo -n "$@..." || true
 }
 
 log_action_end_msg () {

--- End Message ---
--- Begin Message --- 
Source: lsb
Source-Version: 4.1+Debian10

We believe that the bug you reported is fixed in the latest version of
lsb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 708337@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <odyx@debian.org> (supplier of updated lsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 15 May 2013 11:06:44 +0200
Source: lsb
Binary: lsb-core lsb-graphics lsb-cxx lsb-desktop lsb-languages lsb-multimedia lsb-printing lsb-security lsb lsb-base lsb-release lsb-invalid-mta
Architecture: source amd64 all
Version: 4.1+Debian10
Distribution: unstable
Urgency: low
Maintainer: Debian LSB Team <debian-lsb@lists.debian.org>
Changed-By: Didier Raboud <odyx@debian.org>
Description: 
 lsb        - Linux Standard Base 4.1 support package
 lsb-base   - Linux Standard Base 4.1 init script functionality
 lsb-core   - Linux Standard Base 4.1 core support package
 lsb-cxx    - Linux Standard Base 4.1 C++ support package
 lsb-desktop - Linux Standard Base 4.1 Desktop support package
 lsb-graphics - Linux Standard Base 4.1 graphics support package
 lsb-invalid-mta - Linux Standard Base sendmail dummy
 lsb-languages - Linux Standard Base 4.1 Runtime Languages package
 lsb-multimedia - Linux Standard Base 4.1 Multimedia package
 lsb-printing - Linux Standard Base 4.1 Printing package
 lsb-release - Linux Standard Base version reporting utility
 lsb-security - Linux Standard Base 4.1 Security package
Closes: 673586 708337
Changes: 
 lsb (4.1+Debian10) unstable; urgency=low
 .
   [ Steve Langasek ]
   * Fix the remaining problems of initdutils.py python3 compatibility
     (Closes: #673586)
   * Revert unnecessary use of /bin/echo -n (Closes: #708337)
 .
   [ Didier Raboud ]
   * Compress source with xz
Checksums-Sha1: 
 ad0fc90cc8733c0c3394bc34eabe6916f338c299 2044 lsb_4.1+Debian10.dsc
 95538251356c63f790fb8a8c3a1618897e4cc651 119148 lsb_4.1+Debian10.tar.xz
 82623016167cc6f79a3d700fae632d6e68217fb6 43992 lsb-core_4.1+Debian10_amd64.deb
 87ff8cc22b30b89b0a4546c17cee9b28e0978a64 19060 lsb-graphics_4.1+Debian10_amd64.deb
 f01a1bb3be0c14f46d216563cd9c395a45d63a8c 19032 lsb-cxx_4.1+Debian10_amd64.deb
 e874cadbc4c387c48c3c81d0e806cef60ec3e7ef 20250 lsb-desktop_4.1+Debian10_amd64.deb
 c8f59264c378fe5c30c1f86e0c27490614be7927 19066 lsb-languages_4.1+Debian10_amd64.deb
 c89e1c07ded1f205b2d791ee1a0d48dd1bdb98ec 19032 lsb-multimedia_4.1+Debian10_amd64.deb
 d6f93e11c59177fc09b80ded87ea5a530cfc5ee8 19058 lsb-printing_4.1+Debian10_amd64.deb
 ef00a6ba180086270e330dab338fd9e859ce8bd7 19048 lsb-security_4.1+Debian10_amd64.deb
 c90af33b029e8801a60118479d9ad60de473bca2 19026 lsb_4.1+Debian10_all.deb
 93328ece8a3fb86100ffe1446dac879b0acb79aa 26464 lsb-base_4.1+Debian10_all.deb
 bf51fd4ebaa5389a328b4dfa94b0705455a50a6c 25976 lsb-release_4.1+Debian10_all.deb
 5011b406ffd59216bacc965022922d03d41f2d96 19412 lsb-invalid-mta_4.1+Debian10_all.deb
Checksums-Sha256: 
 c94b20e0cc22d0eee31e5fdd242f209f399dc06437ec41a50a5888d4f95dd475 2044 lsb_4.1+Debian10.dsc
 2da4936d00029a29de0ab0834268c71c0b65244b53bc31669fceb9f8cca82dd2 119148 lsb_4.1+Debian10.tar.xz
 e79b230d77ce67547f837f2fb509b0f464ffd85158cb6319ecc8ae62d58eea7d 43992 lsb-core_4.1+Debian10_amd64.deb
 d322dddf67f1c0bdadbc5683a8dd5cea825b16362dd6db3a9fc970482ac580b2 19060 lsb-graphics_4.1+Debian10_amd64.deb
 f3cecdec7f5295850e923e7830cf1edbf5a0b63a7940d6309da520c9c106c069 19032 lsb-cxx_4.1+Debian10_amd64.deb
 c12b8acf13fef1162266047fb6a168b8d46d174bcd64b2af44f22c8292b61138 20250 lsb-desktop_4.1+Debian10_amd64.deb
 f2614c68a0e74497828b69b8bf99606c001d25315cc33420448176bfe60f12f8 19066 lsb-languages_4.1+Debian10_amd64.deb
 45dd3a699876542c3c9f65ab980d832d59238562903186e38aa7431e7f58b7c4 19032 lsb-multimedia_4.1+Debian10_amd64.deb
 d0c4a9f80866b1cebfd3c87f69835e6b96de4d492719666d7c2bf34540d115f0 19058 lsb-printing_4.1+Debian10_amd64.deb
 65715f94b6c0a5da94c402cf87a08221082984f0fe78d583e72e3fbcf5ac43b6 19048 lsb-security_4.1+Debian10_amd64.deb
 d114a4ea45fc916b339bac41eadfa1c6bb79f9013f9efe3d5bdbeb0c385ebfdc 19026 lsb_4.1+Debian10_all.deb
 1eb90de9b9859affc2f1a51f1efb0fe353877bb476dd1db1875a931d50546dd1 26464 lsb-base_4.1+Debian10_all.deb
 09a9520d20b1f5b59ab53b02b23cb1202ada24658d79974bd44f293262504a09 25976 lsb-release_4.1+Debian10_all.deb
 248b8e113f64a621fe890442bc6e0d5027645b9eca6e0c72366b56327c11f003 19412 lsb-invalid-mta_4.1+Debian10_all.deb
Files: 
 44e5acc748637dff9c4213653913e936 2044 misc extra lsb_4.1+Debian10.dsc
 c044ffd9b417e7bcbd105e1f132b28ce 119148 misc extra lsb_4.1+Debian10.tar.xz
 a593c4e0e4871148057847d5fc85c54b 43992 misc extra lsb-core_4.1+Debian10_amd64.deb
 6c02ec20ba0cdd4f8b1bfe9c464dac38 19060 misc extra lsb-graphics_4.1+Debian10_amd64.deb
 5a1e2ee38f83fb3974b148ed87d7665e 19032 misc extra lsb-cxx_4.1+Debian10_amd64.deb
 45e45fe205187c66fe7dd863ded5b191 20250 misc extra lsb-desktop_4.1+Debian10_amd64.deb
 cec09e50a4d71ecb593df52718f04950 19066 misc extra lsb-languages_4.1+Debian10_amd64.deb
 a5dff9bd5b02f24ba986422f45d189ea 19032 misc extra lsb-multimedia_4.1+Debian10_amd64.deb
 6c30e6c238025d359d5e85d4b32b92c1 19058 misc extra lsb-printing_4.1+Debian10_amd64.deb
 5cab296a7d12a19d5adb616fdb2d85f7 19048 misc extra lsb-security_4.1+Debian10_amd64.deb
 86203ec360062f6b51fe9e465243b2d5 19026 misc extra lsb_4.1+Debian10_all.deb
 7566698566f4e22c88354977f47b7b33 26464 misc required lsb-base_4.1+Debian10_all.deb
 db5daf23294070cbe14797342c35c0ff 25976 misc optional lsb-release_4.1+Debian10_all.deb
 17dd7a5fdb2eb60da733565498de90a1 19412 misc extra lsb-invalid-mta_4.1+Debian10_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQGcBAEBCAAGBQJRk2rwAAoJEIvPpx7KFjRVZ5AMAIisgicsa34s8DJkXjjOBPa2
TZbfVVxNFasyox3ah33qFBJKAzf5MDFabn6XoppaZOSo3rBxFXm4HEPCv63YlvRP
lZEkWH5WWVGexHWhQb8P5tEKO6vhrRxoKOCzDhwkL6ugY2HSsDXj+p/nQr6heTQy
G7/9qZRkH1sE9Z9AWfjV66qaI2rdT1+o+rg6VqZCyiKaLW/X4T2YjC7tdKDrfM/Q
1SQhoQ06JpHZLcH07Kro1Kiq0DAP6siykKRVgRnMQGteYBmlQoTh40mj7hEB/6Sh
VD2l6f5iRpk3auWJKe2C4AeVkoXh2yX1/AQvrqvY7l2NJoKaNFzPjelkvPS1RZrb
Ge8VAF30smktcbjyrivnwwGtjtPOBjTiNDehIVTeTmuSWxL5eO+Lsk4jzPq97eNj
otYDPyrq+wEff+7jQIRVWSAZfJfxEDKbMIkb1bK2OYf5ITXonE1yr3w2qYzcU/bI
b46h/iOI1nOrjrRdoUkoLBpEN9vlVgrKpqg7HovC1Q==
=vrgK
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: