[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#693688: The last patch to fix #691422 breaks other init scripts



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

Thanks for this fast response.

Am Mo den 19. Nov 2012 um 11:50 schrieb Didier 'OdyX' Raboud:
> Le lundi, 19 novembre 2012 10.51:21, Klaus Ethgen a écrit :
> > The last patch to fix #691422 will break init scripts of unrelated
> > software like for example exim. Please roll it back. I set the severity
> > to critical for this reason; breaking unrelated software.
> 
> As I can't verify your assertion here, using Wheezy's exim's initscript, and 
> as:
> 
> $ grep pidofproc /etc/init.d/exim4 
>   if pidofproc -p "$QRPIDFILE" >/dev/null; then
>   if pidofproc -p "$PIDFILE" >/dev/null; then
> 
> Could you please detail your "will break init scripts of unrelated software" ? 
> (tagging as +moreinfo)

Well, /etc/init.d/exim4 status end with return code 4 after the update;
in any cases. (That was how I saw it, as puppet do use it to see if the
daemon is running.)

> As discussed in #691422, pidofproc was never meant to be used with a different 
> arguments order,

I do not know about the intended use. I never dig into pidofproc before.
I just know that exim init script (and maybe other) is broken after
updating lsb-base.

> so I think it's not an lsb-base responsibility if other init scripts
> wrongly using it now fail when it enforces a correct behaviour.

That might be. But shouldn't it be checked before make an incompatible
change and notifying the relevant maintainers?

> For now, I'm downgrading this to serious.

No problem with that. I set the severity just according the
corresponding notes in bugreport.

Regards
   Klaus
- -- 
Klaus Ethgen                              http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen <Klaus@Ethgen.de>
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQGcBAEBCgAGBQJQqhheAAoJEKZ8CrGAGfasbSQL/itOziu1sWYhK26zn9H8I24a
X86+gM5FEHNro4FL/EwbrusiMZLgWSKtm0Lm4akSeySMmsRhrDbZdyiN2KoioFhG
AYXEo5uNcemslRIx9fjWw6EhAj8b4+51ft/Z0Y4FnKrY1VlM6hlBGYmNYoS7X+/K
xWT/5+JQLQs8ALJtFPnj9W6LVzucbsXp3pCLQ5jqxUjeAsmbUExvYAwylKJhk5ty
iMHQSaNDxZYExdZJChZiXEs/odRPsuak0WhKzgJftnV+UF3oMGkmc8FCLc3oojny
yRPfRtIb67VGH1FGWI3RaXrgxNq60/xxfr/SV7+W/xiYvug7kbxJYSioUfUGjoWW
kSJC7hJ5NcZduABCWZeYDq4mddjN+9sQfjo8M7vYZGk2iPJRbmDSIUuOR+rS6iGH
KY0HrpwVXv8zeQBU4wMsg9Llll7yCg2OhnB05KxkIulBEKbVTLAPNcaRIcA6OLlS
rsDO346w9wErVn3gfvE/a3g4Ln3gYcaJgPv0Yhe+Vg==
=xJdv
-----END PGP SIGNATURE-----


Reply to: