[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683654: lsb-base: some messages should be conditioned by $VERBOSE



tags 683654 +moreinfo
thanks

Le jeudi, 2 août 2012 16.38:41, Teodor a écrit :
> In Debian the recommendation for all init scripts is to check the variable
> VERBOSE from /etc/default/rcS and only print a message on console only if
> this variable is not 0.

From the content of the debian-policy package, I don't think that's true; can 
you point me to where this recommendation comes from ?

> This should be adopted by init-functions too, at least for some of the
> functions that print [info] tags.

As only the init scripts themselves can know which of the messages handed to 
the log_msg_* functions are important or not, I think the responsability of 
handling an eventual VERBOSE variable is upon the individual iniscripts and 
not upon lsb-base.

Le mardi, 7 août 2012 11.55:40, Dmitry Smirnov a écrit :
> Is that correct that [info] messages are only printed by 'log_action_msg'?

Correct.

> It may be used for messages like "service is already running" and I'm not
> sure if we want to suppress such messages.

Indeed, there's no way to differentiate useful from useless log messages.

I think that the fact that a call to log_*_msg always leads to having a 
message printed is actually a feature and a characteristic of these shell 
functions. Changing this interface to start printing messages conditionally is 
a quite intrusive change IMHO.

Although I would have been tempted to directly tag +wontfix or mark the bug -
done, I'm hereby tagging as +moreinfo to see if I can get convinced.

Cheers,

OdyX


Reply to: