[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1111039: rsync calls



On Fri, 15 Aug 2025 18:37:24 +0100 Luca Boccassi <bluca@debian.org>
wrote:
> On Fri, 15 Aug 2025 at 01:10, Luca Boccassi <bluca@debian.org> wrote:
> >
> > On Thu, 14 Aug 2025 at 23:41, Luca Boccassi <bluca@debian.org>
wrote:
> > >
> > > On Thu, 14 Aug 2025 at 20:11, Luca Boccassi <bluca@debian.org>
wrote:
> > > >
> > > > On Thu, 14 Aug 2025 at 19:54, Roland Clobus
<rclobus@rclobus.nl> wrote:
> > > > >
> > > > > On 14/08/2025 20:07, Luca Boccassi wrote:
> > > > > > Would anyone be able to point me to where these rsync calls
are made,
> > > > > > please? Tried looking around in live-build and couldn't
find them.
> > > > >
> > > > > Those rsync calls are not in live-build.
> > > > >
> > > > > One is in Calamares:
> > > > >
https://sources.debian.org/src/calamares/3.3.14-3/src/modules/unpackfs/main.py?hl=181#L181
> > > > > The other one is somewhere in the d-i, I don't have a URL at
hand at the
> > > > > moment.
> > > > >
> > > > > Here is the code to remove the live-related packages in d-i:
> > > > >
https://sources.debian.org/src/live-installer/58/finish-install.d/14remove-live-packages
> > > >
> > > > Is this 14remove-live-packages called also when calamares is in
use,
> > > > given it removes calamares-settings-debian? If so I could add
the
> > > > logic there
> > >
> > > Can someone review
> > >
https://salsa.debian.org/installer-team/live-installer/-/merge_requests/4
> > > please - tested with the d-i live installer image and it does
what it
> > > says on the tin
> >
> > And same for Calamares:
> >
> >
https://salsa.debian.org/live-team/calamares-settings-debian-packaging/-/merge_requests/6
> >
> > Once these get a +1 I'll team upload them, and that together with
the
> > already uploaded live-build changes fixes new images. Need to
figure
> > out if we need p-u uploads of the d-i packages or not, not sure.
> 
> Jonathan suggested using live-boot.postrm instead of hooks in the
> installer package, I've tested and it works with both flavours, so
> I've uploaded live-boot now. I'll prep the same p-u update as well
> shortly.

Uploaded to unstable and trixie-p-u.

Unless someone has a better (actionable) idea, I'll put the following
postinst cleanup in init-system-helpers which is prio: essential so
it's guaranteed to clean up every install:

if [ "$1" = "configure" ] && [ -n "$2" ] && dpkg-divert --list /etc/os-release | grep -q os-release.debootstrap; then
    dpkg-divert --quiet --local --remove --no-rename /etc/os-release
    rm -f /etc/os-release
    ln -s ../usr/lib/os-release /etc/os-release
fi

and push that to p-u as well


Reply to: