Bug#1078442: live-build: zsync removal from testing prevents building images based on trixie

[NoisyCoil <noisycoil@tutanota.com>]

Package: live-build
Version: 1:20240810
Severity: important
Tags: patch
X-Debbugs-Cc: noisycoil@tutanota.com

Dear Maintainer,

The recent auto-removal of zsync from testing
(https://tracker.debian.org/news/1553820/zsync-removed-from-testing/) prevents
live-build from building images based on trixie. The build fails with error

[2024-08-10 15:36:11] lb binary_zsync
P: Begin building zsync control files...
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package zsync
E: An unexpected failure occurred, exiting...

I think the removal was triggered by the package being orphaned + FTBFS with
gcc-14 (see bug #1075710). If you are interested in fixing the problem and
re-upload zsync to testing, I am attaching a patch that solves the build
failure by restoring its behavior to what it was pre-gcc-14.

Note that this bug does not affect building images based on bookworm (nor
presumably on unstable, but I didn't check this explicitly).

Best,

NoisyCoil

>From 4d11835d376899258946d52b54cfe444432f6d94 Mon Sep 17 00:00:00 2001
From: NoisyCoil <noisycoil@tutanota.com>
Date: Sat, 10 Aug 2024 15:07:43 +0200
Subject: [PATCH] Compile with -Wno-error=incompatible-pointer-types

Closes: #1075710
---
 debian/changelog | 7 +++++++
 debian/rules     | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index ec9bbe6..fd1ce32 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+zsync (0.6.2-6) UNRELEASED; urgency=medium
+
+  * Compile with -Wno-error=incompatible-pointer-types to avoid
+    FTBFS with gcc-14 (Closes: #1075710)
+
+ -- NoisyCoil <noisycoil@tutanota.com>  Sat, 10 Aug 2024 15:06:03 +0200
+
 zsync (0.6.2-5) unstable; urgency=medium
 
   * QA upload.
diff --git a/debian/rules b/debian/rules
index 2cab487..bea4b88 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,7 +8,7 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 # see ENVIRONMENT in dpkg-buildflags(1)
 # package maintainers to append CFLAGS
-#export DEB_CFLAGS_MAINT_APPEND  = -Wall -pedantic
+export DEB_CFLAGS_MAINT_APPEND  = -Wno-error=incompatible-pointer-types
 # package maintainers to append LDFLAGS
 export DEB_LDFLAGS_MAINT_APPEND =
 
-- 
2.43.0