[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1028627: marked as done (live-tools: Typo in a kernel parameter name)

Your message dated Sat, 25 May 2024 16:35:11 +0000
with message-id <E1sAuMR-00DmYS-Nj@fasolo.debian.org>
and subject line Bug#1028627: fixed in live-tools 1:20240525
has caused the Debian Bug report #1028627,
regarding live-tools: Typo in a kernel parameter name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1028627: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028627
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-tools
Version: 1:20190831
Severity: normal
Tags: patch
X-Debbugs-Cc: adam.vodopjan@gmail.com

Dear Maintainer,

I've found a typo in a kernel parameter name in live-tools package:
'find_iso' instead of 'findiso'. It affects reboot/shutdown process in a
multiboot scenario.

So I created a multiboot disk image based on grub config from
https://wiki.debian.org/DebianLive/MultibootISO and put there latest
debian 8, 9, 10, 11 iso.

Next I boot into some iso with the disk and try to reboot or shutdown. In
case of debian 8/9 it just works (because of another bug fixed in debian
10: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831830), in case of
debian 10/11 there is a 90 secs countdown for the user to press Enter.

Let me outline it clearly: the problem dates to the times 'findiso' thing
was implemented, it was NOT introduced in debian 10.

So in debian 10 on reboot/shutdown I get such message with a countdown:

A stop job is running for live-tools - System Support Scripts (xx /
1min 30s)

If I press Enter during the countdown, it proceeds immediately.

In debian 11 case there is no visible countdown, but such message:

Please remove the live-medium, close the tray (if any) and press ENTER
to continue

The message goes away in 90 secs by itself so there is a countdown similar
to the debian 10 case but a hidden one.

Here is the source of the problem:

/bin/live-medium-eject:

18: # Exit if system is findiso
19: grep -qs "find_iso" /proc/cmdline || \

Evidently, it should be 'findiso'. With the typo fixed reboot/shutdown
performs flawlessly.

-- System Information:
Debian Release: 11.6
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set 
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages live-tools depends on:
ii initramfs-tools 0.140
ii lsb-base 11.1.0

live-tools recommends no packages.

Versions of packages live-tools suggests:
pn debian-installer-launcher <none>
ii eject 2.36.1-8+deb11u1
ii perl 5.32.1-4+deb11u2
ii procps 2:3.3.17-5
ii rsync 3.2.3-4+deb11u1
ii uuid-runtime 2.36.1-8+deb11u1

-- no debconf information


diff --git a/bin/live-medium-eject b/bin/live-medium-eject
index f4f37c4..2414b2d 100755
--- a/bin/live-medium-eject
+++ b/bin/live-medium-eject
@@ -16,7 +16,7 @@ if ! grep -qs "boot=live" /proc/cmdline || \
    grep -qs "root=/dev/nfs" /proc/cmdline || \
    grep -qs "root=/dev/cifs" /proc/cmdline || \
 # Exit if system is findiso
-   grep -qs "find_iso" /proc/cmdline || \
+   grep -qs "findiso" /proc/cmdline || \
 # Exit if system is toram
    grep -qs "toram" /proc/cmdline || \
 # Exit if user disabled medium eject

--- End Message ---
--- Begin Message --- 
Source: live-tools
Source-Version: 1:20240525
Done: Luca Boccassi <bluca@debian.org>

We believe that the bug you reported is fixed in the latest version of
live-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1028627@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luca Boccassi <bluca@debian.org> (supplier of updated live-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 May 2024 12:50:57 +0100
Source: live-tools
Architecture: source
Version: 1:20240525
Distribution: unstable
Urgency: medium
Maintainer: Debian Live Maintainers <debian-live@lists.debian.org>
Changed-By: Luca Boccassi <bluca@debian.org>
Closes: 970286 1028627
Changes:
 live-tools (1:20240525) unstable; urgency=medium
 .
   [ Juergen Fiedler ]
   * Fix the check for executable rsync.
   * Fix check for live media to unmount.
   * Unmount live media from all mount points
 .
   [ Lyndon Brown ]
   * amend copyright,urls
   * "Live Systems" -> "Debian Live"
 .
   [ Raphaël Hertzog ]
   * Drop Iain R. Learmonth from Uploaders on his request (Closes: #970286)
 .
   [ Adam Vodopjan ]
   * Fix typo in a kernel parameter name (Closes: #1028627)
 .
   [ Luca Boccassi ]
   * Bump debhelper-compat to 13
   * Add myself as maintainer
   * d/control: bump Standards-Version to 4.7.0, no changes
   * Use a mask instead of a stub unit file to hide generated initrd
     service
   * Install files to /usr/
   * Drop dependency on obsolete lsb-base
 .
   [ Steven Shiau ]
   * Make live-medium-eject work for systemd >= 253.
Checksums-Sha1:
 94d7d79fff21513e4126fa45919ef228d740cc56 1730 live-tools_20240525.dsc
 e5100f50a4458a254d60bbf2c594c68513d00b1d 36224 live-tools_20240525.tar.xz
 9284a9c565c65aa141155a577cb7131780184aa9 6586 live-tools_20240525_source.buildinfo
Checksums-Sha256:
 1ddeb980d3d3ed7b3a08b96ae2499e2b52581999a140f83cb26b3126ee8566a8 1730 live-tools_20240525.dsc
 46cd50c0e57886b9d7ce4d971ad243a8b75ae116b8da903e3c9e55415bec41b1 36224 live-tools_20240525.tar.xz
 995ca0b0fae45ee9385e7c6402df5e9b8c4c54a7ef4503e909ad6c0a495609f7 6586 live-tools_20240525_source.buildinfo
Files:
 c59dddfb8fa1af2e6f54a51edda2f659 1730 misc optional live-tools_20240525.dsc
 db76a056e270483d75b39766c1294851 36224 misc optional live-tools_20240525.tar.xz
 4f1ca83e6d41b603e269e490c9c19f49 6586 misc optional live-tools_20240525_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEErCSqx93EIPGOymuRKGv37813JB4FAmZSDKcRHGJsdWNhQGRl
Ymlhbi5vcmcACgkQKGv37813JB4+Lg/+PFEzL7khqf6kEOleyawb0Jojm+6FxzW5
NLNU3S71+wZiUMV6dahr3abMn0Qu/86DVCJLSprYBybGS5R8g47KOYuEg/Jf5RpE
KFocgZk6Z7JllXs2kUnUL2fPw7IY5kt+8XMbh70z9ewlwlMkDLvVxgDbylV39UUZ
g8SENFYo5Cug1JSEhtPn+31zkqBA58+vcjLGZVy0lLuqDfR6g7ZFsaJ1UBoiISEb
HDS5eCIZNCTZwp6Sf2nyP2V0zaPXldofPPdLDbKBYwunZLiE8s/ehUG7VnGXzVlN
j4Fzgji0uYuRRbfFMqUCf8kdNNT70FvSW2mYOo+9McF/vwaulHTwNsiEzQ9DKuT5
l3zA0x3Zydug7wnwCaYu8ethO5BXZzEgBsi6J0V7WAXGb+GxNLPU3fJhhkwCyNJz
j8+1yuiqFgHo2gVBp1j1T+NnKGDFVk3juLohYVaaaiaWEN4QAlxe98HQWBKi8dEt
o1Mdj1UzLcHp0H9P0q572zHYxtLby+xcvvQ76V9yF3QJdWVPujxWN/pUDt1nhVXe
eDrMQX8YAujuQECdJllRymxdRIk1QyBqffyHFn8PvfEJQ1AHZMEeVmiDcPffzWhT
+EfQBIZp7ZhvdYLqBe7rwN2xFfp7Ld5Q5Wfv2gywV2tiYrAyO1XsEv4ERaJW7Hq5
k50HAxhAvbg=
=6QsP
-----END PGP SIGNATURE-----

Attachment: pgplTcIzkVCSK.pgp
Description: PGP signature


--- End Message ---
Reply to: