Bug#1028627: live-tools: Typo in a kernel parameter name
Package: live-tools
Version: 1:20190831
Severity: normal
Tags: patch
X-Debbugs-Cc: adam.vodopjan@gmail.com
Dear Maintainer,
I've found a typo in a kernel parameter name in live-tools package:
'find_iso' instead of 'findiso'. It affects reboot/shutdown process in a
multiboot scenario.
So I created a multiboot disk image based on grub config from
https://wiki.debian.org/DebianLive/MultibootISO and put there latest
debian 8, 9, 10, 11 iso.
Next I boot into some iso with the disk and try to reboot or shutdown. In
case of debian 8/9 it just works (because of another bug fixed in debian
10: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831830), in case of
debian 10/11 there is a 90 secs countdown for the user to press Enter.
Let me outline it clearly: the problem dates to the times 'findiso' thing
was implemented, it was NOT introduced in debian 10.
So in debian 10 on reboot/shutdown I get such message with a countdown:
A stop job is running for live-tools - System Support Scripts (xx /
1min 30s)
If I press Enter during the countdown, it proceeds immediately.
In debian 11 case there is no visible countdown, but such message:
Please remove the live-medium, close the tray (if any) and press ENTER
to continue
The message goes away in 90 secs by itself so there is a countdown similar
to the debian 10 case but a hidden one.
Here is the source of the problem:
/bin/live-medium-eject:
18: # Exit if system is findiso
19: grep -qs "find_iso" /proc/cmdline || \
Evidently, it should be 'findiso'. With the typo fixed reboot/shutdown
performs flawlessly.
-- System Information:
Debian Release: 11.6
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE
not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages live-tools depends on:
ii initramfs-tools 0.140
ii lsb-base 11.1.0
live-tools recommends no packages.
Versions of packages live-tools suggests:
pn debian-installer-launcher <none>
ii eject 2.36.1-8+deb11u1
ii perl 5.32.1-4+deb11u2
ii procps 2:3.3.17-5
ii rsync 3.2.3-4+deb11u1
ii uuid-runtime 2.36.1-8+deb11u1
-- no debconf information
diff --git a/bin/live-medium-eject b/bin/live-medium-eject
index f4f37c4..2414b2d 100755
--- a/bin/live-medium-eject
+++ b/bin/live-medium-eject
@@ -16,7 +16,7 @@ if ! grep -qs "boot=live" /proc/cmdline || \
grep -qs "root=/dev/nfs" /proc/cmdline || \
grep -qs "root=/dev/cifs" /proc/cmdline || \
# Exit if system is findiso
- grep -qs "find_iso" /proc/cmdline || \
+ grep -qs "findiso" /proc/cmdline || \
# Exit if system is toram
grep -qs "toram" /proc/cmdline || \
# Exit if user disabled medium eject
Reply to: