[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#913001: marked as done (live-wrapper: Handle firmware list more robustly by using proper whitespace split)

Your message dated Fri, 24 Jun 2022 14:49:51 +0000
with message-id <[🔎] E1o4kd5-0009Pq-1L@fasolo.debian.org>
and subject line Bug#1009282: Removed package(s) from unstable
has caused the Debian Bug report #913001,
regarding live-wrapper: Handle firmware list more robustly by using proper whitespace split
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
913001: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913001
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-wrapper
Version: 0.7
Severity: normal
Tags: patch

Hi,

Patch against current master branch in attachement.

"
    Fix splitting of firmare package names
    
    split(' ') literally splits on a single space:
    
    'firmware-a  firmware-b'.split(' ') == ['firmware-a', '', 'firmware-b']
    
    Use split() that automatically removes empty elements (equivelent to
    strip + remove if empty), and splits on tabs and newlines.
    
    This makes human provided arguments be handled more robustly.
"

Thanks.

commit dc2c8f3376fafcc35846f2e75a4c4f6393bb3590
Author: Witold Baryluk <witold.baryluk@gmail.com>
Date:   Mon Nov 5 19:27:08 2018 +0000

    Fix splitting of firmare package names
    
    split(' ') literally splits on a single space:
    
    'firmware-a  firmware-b'.split(' ') == ['firmware-a', '', 'firmware-b']
    
    Use split() that automatically removes empty elements (equivelent to
    strip + remove if empty), and splits on tabs and newlines.
    
    This makes human provided arguments be handled more robustly.

diff --git a/lwr/run.py b/lwr/run.py
index a2fe103..0982f5f 100644
--- a/lwr/run.py
+++ b/lwr/run.py
@@ -322,7 +322,7 @@ class LiveWrapper(cliapp.Application):
                                       self.settings['mirror'],
                                       self.settings['distribution'],
                                       self.settings['architecture'])
-            for pkg in self.settings['firmware'].split(' '):
+            for pkg in self.settings['firmware'].split():
                 filename = handler.download_package(pkg, fw_root)
             handler.clean_up_apt()
             logging.info("... firmware deb downloads")

--- End Message ---
--- Begin Message --- 
Version: 0.10+rm

Dear submitter,

as the package live-wrapper has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1009282

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)

--- End Message ---
Reply to: