Bug#884553: live-build: Foreign architecture package support for linux kernel flavours in Stretch
Hi,
On Sun, 18 Nov 2018, adrian15 wrote:
> After testing this change the Grub menu which should have two kernel
> entries has only one. It might be other of my patches are pending of
> applying or somewhat I messed up with this patch.
It's up to you to figure this. I won't do it for you. And I won't merge
the patch until you have something working entirely.
> I know modifying the live-manual package is pending. I prefer waiting
> for your feedback on my new implementation before commiting work on
> live-manual.
The attached patch looks acceptable. The only small comments are below:
> Once you have done this thanks to this commit
> now you can set linux flavours ( --linux-flavours ) as:
>
> "i386 amd64:amd64"
>
> in a i386 system and it will install the amd64 kernel alongside the i386 system.
This should really be part of the documentation (manual page) because
right now the explanation is not clear on what it brings:
> .IP "\-k|\fB\-\-linux\-flavours\fR \fIFLAVOUR\fR|""\fIFLAVOURS\fR""" 4
> -sets the kernel flavours to be installed. Note that in case you specify more than that the first will be configured the default kernel that gets booted.
> +sets the kernel flavours to be installed. Note that in case you specify more than that the first will be configured the default kernel that gets booted. Optionally you can use an architecture qualifier, e.g. amd64:amd64, so that it works ok when you add a foreign architecture to your build system.
That's the part to be expanded.
> --- a/scripts/build/config
> +++ b/scripts/build/config
> @@ -1133,7 +1133,7 @@ LB_KEYRING_PACKAGES="${LB_KEYRING_PACKAGES}"
>
> # \$LB_LINUX_FLAVOURS: set kernel flavour to use
> # (Default: autodetected)
> -LB_LINUX_FLAVOURS="${LB_LINUX_FLAVOURS}"
> +LB_LINUX_FLAVOURS_WITH_ARCH="${LB_LINUX_FLAVOURS}"
I think you need to update all 3 occurences of LB_LINUX_FLAVOURS in this
hunk... not only the name of the variable being assigned.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Reply to: