[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#891206: marked as done (live-build: using local offline mirrors fails due to regression)

Your message dated Wed, 28 Mar 2018 19:50:24 +0000
with message-id <E1f1H5U-000Esl-KL@fasolo.debian.org>
and subject line Bug#891206: fixed in live-build 1:20180328
has caused the Debian Bug report #891206,
regarding live-build: using local offline mirrors fails due to regression
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
891206: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891206
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-build
Version: 1:20161202
Tags: patch
Severity: normal

Dear Maintainer,

Commit a15b5796 (#775989) [1] dropped an early exit from the
chroot_archives remove step in case the parent mirror chroot and binary
parameters are the same and unfortunately introduced a regression in an
(infrequent) corner case, as with the following live-build now fails
when the parent mirror is using a file:/ local apt repository (for
example when the build worker is offline and uses a pre-built cache of
packages).

Example config:

lb config --mirror-bootstrap "file:/pkgs" \
    --mirror-chroot "file:/pkgs/" \
    --mirror-binary "file:/pkgs" \
    --parent-mirror-bootstrap "file:/pkgs" \
    --parent-mirror-chroot "file:/pkgs/" \
    --parent-mirror-binary "file:/pkgs" \
    ...

with /pkgs being a directory with the packages for the installation and
the apt metadata (Packages/Sources/Release).

The problem is that, with such a setup, the /pkgs directory is bind
mounted inside the chroot as an optimisation in the install step,
and umounted as one of the first actions in the remove step for
chroot_archives.

Before that fix, the script terminated immediately. But now it
progresses and at the end it tries to run apt update inside the chroot
which will fail since the repository directory has been umounted, and
thus the packages and the apt metadata are no longer available, while
still being listed in /etc/apt/sources.list.

The proposed solution is to avoid running apt update in the chroot at
the end of the chroot_archives remove step if the repository is local
and has been umounted.

A PR [2] has been opened on Salsa with the proposed fix. Please let me
know if you'd like more information or a different solution.

Thanks!

-- 
Kind regards,
Luca Boccassi

[1] https://salsa.debian.org/live-team/live-build/commit/a15b579652e64317fbcc0597a1ea1012fb1d3ba8
[2] https://salsa.debian.org/live-team/live-build/merge_requests/1

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
Source: live-build
Source-Version: 1:20180328

We believe that the bug you reported is fixed in the latest version of
live-build, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 891206@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luca Boccassi <bluca@debian.org> (supplier of updated live-build package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 28 Mar 2018 20:20:46 +0100
Source: live-build
Binary: live-build
Architecture: source
Version: 1:20180328
Distribution: unstable
Urgency: low
Maintainer: Debian Live <debian-live@lists.debian.org>
Changed-By: Luca Boccassi <bluca@debian.org>
Description:
 live-build - Live System Build Components
Closes: 821084 847919 867539 884585 884588 884591 885692 887278 891206 892406
Changes:
 live-build (1:20180328) unstable; urgency=low
 .
   [ Raphaël Hertzog ]
   * Restore i386/amd64 autodetection in grub after rename of
     i386 kernel from -486 to -686. Closes: #884585
     Thanks to Adrian Gibanel Lopez for the patch.
   * Fix handling of multiple kernels in binary_loopback_cfg.
     Closes: #884588 Thanks to Adrian Gibanel Lopez for the patch.
   * Rework failsafe entries in grub configuration to be more
     consistent with the i386/amd64 autodetection entries.
     Closes: #884591 Thanks to Adrian Gibanel Lopez for the patch.
   * Add e2fsprogs to Suggests along with mtd-utils, parted. Closes: #887278
   * Fix Check_package invocation in binary_hdd for ntfs-3g
     (/sbin/mkfs.nfts -> /sbin/mkfs.ntfs)
   * Run mksquashfs with nice -n 19 to not overload the system.
     Thanks to Ronny Standtke for the patch. (Closes: #867539)
 .
   [ Luca Boccassi ]
   * Fix build with local offline mirrors (Closes: #891206)
 .
   [ Rohan Garg ]
   * Simplify bootstrapping of foreign architectures with qemu-debootstrap
     (Closes: #847919)
 .
   [ Steven Shiau ]
   * Add grub-based UEFI boot support for ARM64 (Closes: #885692)
 .
   [ Luca Boccassi ]
   * UEFI: add minimal grub.cfg to fat32 partition (Closes: #892406)
   * UEFI: add support for Secure Boot on amd64 and arm64 (Closes: #821084)
   * UEFI: use uppercase EFI directory name for Tianocore
   * Add NEWS file to warn users about change of live-boot mount paths
   * Add options to build ONIE images
   * Add Acquire::AllowInsecureRepositories to fix apt-secure in sid
   * Use HTTPS in debian/copyright (policy 4.0.0).
   * Bump Standards-Version to 4.1.3.
   * Add myself to Uploaders.
Checksums-Sha1:
 2bb91698935a037d60f0a29481fab9d0f23c1715 1387 live-build_20180328.dsc
 46bc43789d84dda51ed03fa059d142c0f0c7fadb 361620 live-build_20180328.tar.xz
 806775a55de3524ba3d671db826f001deaea7c00 6195 live-build_20180328_source.buildinfo
Checksums-Sha256:
 1812e471b280f5b36daa3d2f07771a31ce62298857f0bfdf6f1548aa254d6f60 1387 live-build_20180328.dsc
 478633fba556169327836bc10c4dfae2f6b27f0291aa1b9fc3e25e05b4e6c77a 361620 live-build_20180328.tar.xz
 f5417efb2bf5fd04c5bccd2c9c7d923284dcb090415b3bc40c81fe53d838bf7b 6195 live-build_20180328_source.buildinfo
Files:
 79278be4a1d1ec649c27e281da782e2f 1387 misc optional live-build_20180328.dsc
 5cec1435c31ae22664d6e7a8a814d4bc 361620 misc optional live-build_20180328.tar.xz
 5a49e94985ce25005db7dbf4b4765865 6195 misc optional live-build_20180328_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFFBAEBCgAvFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlq765ARHGJsdWNhQGRl
Ymlhbi5vcmcACgkQSylmgFB4UWL6mwf+OiR/mBMjfYJRlfVqp/hi18r4l3rk8HH/
EKAgx4k/367RfmeKziT14Kbc7AdvYLmsDit83YCbS+SWrgIHlbd8Gnl6OsJ7Cdnw
/N0qnmAEdjDEHYXGyoJZ/+SiZ2WGf7KbN7FJ8icTNQPcaHFm7CCibyhA5v7bNjv1
EVsk+NTPRVBL4OfHzmN8BJgPraI9K4BRfrkSPNSU8uRxynjSzsXyePqZOi+4kT68
RHPdrWlKRSHdOK40ISZ4slMt+o1CcfuQIbntFtXAjEE8E8ZTEydzGAVSXE33B6lI
PuoFHhtSlq39PGviaoLUlC9JNAN7Ac55atQtQcJIJNmel6myoyUZrg==
=CNnt
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: