[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#800498: marked as done (live-boot: Default the host in fetch urls to be ROOTSERVER)

Your message dated Fri, 23 Jun 2017 14:30:06 +0200
with message-id <20170623123006.jugkk4vidlz5b5zc@home.ouaza.com>
and subject line Re: Bug#800498: live-boot: Default the host in fetch urls to be ROOTSERVER
has caused the Debian Bug report #800498,
regarding live-boot: Default the host in fetch urls to be ROOTSERVER
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
800498: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800498
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: live-boot
Version: 5.0~a5-1
Severity: wishlist
Tags: patch

Would you consider defaulting the host portion of a URL to be the
ROOTSERVER if it is blank?

Reason: this would mean I don't have to customise live.cfg for each
server I deploy it on (because the tftp server also serves the root
image).

So:

     append fetch=tftp:///path/file.ext

doesn't work now, but if the attached patch is applied this would be
assumed since the host is blank:

     append fetch=tftp://${ROOTSERVER}/path/file.ext

-- System Information:
Debian Release: 8.2
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (50, 'testing'), (40, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-0.bpo.2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nur img.orig/lib/live/boot/9990-mount-http.sh img/lib/live/boot/9990-mount-http.sh
--- img.orig/lib/live/boot/9990-mount-http.sh	2014-12-10 19:37:04.000000000 +1000
+++ img/lib/live/boot/9990-mount-http.sh	2015-09-30 14:42:55.796173416 +1000
@@ -25,6 +25,9 @@
 						mount -t ramfs ram "${mountpoint}"
 						mkdir -p "${dest}"
 					fi
+					case "${url}" in
+						*:///*) url="${url%%:///*}://${ROOTSERVER}/${url##*:///}" ;;
+					esac
 					if [ "${webfile}" = "FETCH" ]
 					then
 						case "$url" in

--- End Message ---
--- Begin Message --- 
Version: 1:20160511

On Wed, 30 Sep 2015, Russell Stuart wrote:
> Would you consider defaulting the host portion of a URL to be the
> ROOTSERVER if it is blank?

This was committed a long time ago but we forgot to close the bug.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

--- End Message ---
Reply to: