Bug#831384: live-config: X.Org driver automatic override for VirtualBox is useless and breaks some use cases

[intrigeri@debian.org]

Package: live-config
Version: 5.20160608
Severity: normal
User: tails-dev@boum.org
Usertags: virt-guest for-stretch

Hi,

in live-config we have this code:

  # xorg-driver automatic override for virtualbox
  if [ -e /var/lib/dpkg/info/virtualbox-guest-x11.list ] && echo "${_DEVICE}" | grep -qs '^80EEBEEF'
  then
  	LIVE_XORG_DRIVER="vboxvideo"
  fi

… that forces using the vboxvideo *X.Org* driver if it's installed,
and we're running in VirtualBox.

This breaks starting X when the vboxvideo *kernel* (dkms) driver is
loaded:

  (II) vboxvideo: kernel driver found, not loading.
  (EE) No devices detected.

In that situation, X starts just fine after removing the xorg.conf.d
snippet added by live-config.

Besides, this code seems to be useless nowadays since when the
vboxvideo kernel driver is not present, X.Org successfully autodetects
and uses the vboxvideo X.Org driver (tested on Jessie + kernel from
jessie-backports), even without that xorg.conf.d custom snippet.

So, it seems to me that dropping the code quoted above would fix one
problem, simplify our code base a bit, and should not break anything.

Thoughts?

Cheers,
--
intrigeri