[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#800498: live-boot: Default the host in fetch urls to be ROOTSERVER



Source: live-boot
Version: 5.0~a5-1
Severity: wishlist
Tags: patch

Would you consider defaulting the host portion of a URL to be the
ROOTSERVER if it is blank?

Reason: this would mean I don't have to customise live.cfg for each
server I deploy it on (because the tftp server also serves the root
image).

So:

     append fetch=tftp:///path/file.ext

doesn't work now, but if the attached patch is applied this would be
assumed since the host is blank:

     append fetch=tftp://${ROOTSERVER}/path/file.ext

-- System Information:
Debian Release: 8.2
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (50, 'testing'), (40, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-0.bpo.2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nur img.orig/lib/live/boot/9990-mount-http.sh img/lib/live/boot/9990-mount-http.sh
--- img.orig/lib/live/boot/9990-mount-http.sh	2014-12-10 19:37:04.000000000 +1000
+++ img/lib/live/boot/9990-mount-http.sh	2015-09-30 14:42:55.796173416 +1000
@@ -25,6 +25,9 @@
 						mount -t ramfs ram "${mountpoint}"
 						mkdir -p "${dest}"
 					fi
+					case "${url}" in
+						*:///*) url="${url%%:///*}://${ROOTSERVER}/${url##*:///}" ;;
+					esac
 					if [ "${webfile}" = "FETCH" ]
 					then
 						case "$url" in

Reply to: