[Note: I'm not subscribed, so please Cc me if responding.] Hi, I've noticed that if a .module file lists an image that doesn't exist, it's silently ignored. I thought that at least a warning is warranted in this situation since it may indicate a mistake when preparing the live system. Also, the fact that this is valid (and not an error) isn't documented in the man page but my patch doesn't deal with that. Cheers!
From 427743e1900e10543672bb3110f1a368da88dec3 Mon Sep 17 00:00:00 2001
From: Tails developers <tails@boum.org>
Date: Tue, 16 Dec 2014 14:09:55 +0100
Subject: [PATCH] Logging a warning when an expected image file is missing.
---
components/9990-overlay.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/components/9990-overlay.sh b/components/9990-overlay.sh
index eb75ac2..2431d97 100755
--- a/components/9990-overlay.sh
+++ b/components/9990-overlay.sh
@@ -139,6 +139,8 @@ setup_unionfs ()
log_begin_msg "Mounting \"${image}\" on \"${mpoint}\" via \"${backdev}\""
mount -t "${fstype}" -o ro,noatime "${backdev}" "${mpoint}" || panic "Can not mount ${backdev} (${image}) on ${mpoint}"
log_end_msg
+ else
+ log_warning_msg "Could not find image '${image}'. Most likely it is listed in a .module file, perhaps by mistake."
fi
done
else
--
1.7.10.4
Attachment:
signature.asc
Description: OpenPGP digital signature