[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#772522: live-build 4.0.3-1 does not install casper in ubuntu mode



tags 772522 patch

Patch attached, build against debian-next, please test it ;)


On 08/12/2014 04:38, Rui Miguel P. Bernardo wrote:
> Package: live-build
> Version: 4.0.3-1
> Severity: normal
>
> Dear Maintainer,
>
>     * What led up to the situation?
>
> I wanted to build a live image based on Ubuntu 14.10 utopic using
> latest live-build.
>
>     * What exactly did you do (or not do) that was effective (or
>       ineffective)?
>
> I have created a new build tree with "lb config", copied the files from
> /usr/share/doc/live-build/examples/auto/* to auto/config and then I've
> added the following to config/auto:
>
>         #!/bin/sh
>
>         set -e
>
>         lb config noauto \
>         --mode ubuntu \
>         -d utopic \
>                 "${@}"
>
> I ran "sudo lb clean", recreated the configuration with "lb config" to
> apply the new settings added in auto/config and finally a ran "sudo lb
> build".
>
>     * What was the outcome of this action?
>
> The live image build failed with:
>
>         [2014-12-08 03:19:45] lb chroot_install-packages install
>         P: Begin installing packages (install pass)...
>         Reading package lists...
>         Building dependency tree...
>         Reading state information...
>         E: Unable to locate package live-boot
>         E: Unable to locate package live-config
>         E: Unable to locate package live-config-systemd
>         P: Begin unmounting filesystems...
>         P: Saving caches...
>         Reading package lists...
>         Building dependency tree...
>         Reading state information...
>         user@galaxy:~/live$
>
>     * What outcome did you expect instead?
>
> I expected that a live image of ubuntu utopic was built.
>
> After digging what the problem was I've found that the following two
> commits do not consider ubuntu mode, only debian and wheezy/jessie,
> breaking the whole ubuntu mode of live-build:
>
>         http://live.debian.net/gitweb/?p=live-build.git;a=commitdiff;h=d1eae015774db9e11ddb656ad8bc377c565f503a
>
>         http://live.debian.net/gitweb/?p=live-build.git;a=commitdiff;h=8eaba8ea5ced274ceb8357a64ead3ff05854e9bc
>
> I know that ubuntu mode support not a priority ATM but I was testing
> live-build 4.0.3-1 with ubuntu mode and the this issue came up.
>
> To workaround the problem I've simply edited manually the file
> /usr/lib/live/build/config. I have replaced the content of
> config/package-lists/live.list.chroot file with
>
>         casper
>
> instead of "live-boot live-config live-config-systemd".
>
> Then I clean up the build tree, ran "lb config" again and run "sudo lb
> build" to build the live image, which was then completed and booted
> successfully.
>
> I would provide a patch but I really don't know if you guys want to
> deal with the content of config/package-lists/live.list.chroot using
> just $LB_PARENT_DISTRIBUTION or using $LB_MODE and/or also
> $LB_INITRAMFS or any other solution you may already have.
>
> Thank you.
>
>
> -- Package-specific info:
>
> -- System Information:
> Debian Release: 7.7
>    APT prefers stable-updates
>    APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
> Locale: LANG=pt_PT.UTF-8, LC_CTYPE=pt_PT.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages live-build depends on:
> ii  debootstrap  1.0.64~bpo70+1
>
> Versions of packages live-build recommends:
> ii  cpio                            2.11+dfsg-0.1
> pn  live-boot-doc                   <none>
> pn  live-config-doc                 <none>
> pn  live-manual-html | live-manual  <none>
>
> live-build suggests no packages.
>
> -- no debconf information
>
>

commit 2579050a213de695b0ddfe701c8c70b5e36e9210
Author: jnqnfe <jnqnfe@gmail.com>
Date:   Mon Dec 8 05:17:23 2014 +0000

    Fix broken ability to build ubuntu images due to generating debian-specific live.list.packages file.

diff --git a/scripts/build/config b/scripts/build/config
index e3b1e51..fac2807 100755
--- a/scripts/build/config
+++ b/scripts/build/config
@@ -1353,22 +1353,27 @@ done
 
 if [ ! -e config/package-lists/live.list.chroot ]
 then
-
-cat > config/package-lists/live.list.chroot << EOF
-live-boot
-live-config
-EOF
-
-case "${LB_PARENT_DISTRIBUTION}" in
-	wheezy)
-		echo "live-config-sysvinit" >> config/package-lists/live.list.chroot
-		;;
-
-	*)
-		echo "live-config-systemd" >> config/package-lists/live.list.chroot
-		;;
-esac
-
+	case "${LB_MODE}" in
+		debian)
+			echo "live-boot" >> config/package-lists/live.list.chroot
+			echo "live-config" >> config/package-lists/live.list.chroot
+			case "${LB_PARENT_DISTRIBUTION}" in
+				wheezy)
+					echo "live-config-sysvinit" >> config/package-lists/live.list.chroot
+					;;
+				*)
+					echo "live-config-systemd" >> config/package-lists/live.list.chroot
+					;;
+			esac
+			;;
+
+		ubuntu)
+			echo "casper" >> config/package-lists/live.list.chroot
+			;;
+
+		*)
+			;;
+	esac
 fi
 
 cat > config/build << EOF

Reply to: