[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#739729: live-build: "Live" installer CD includes redundant .deb files



Package: live-build
Version: 3.0.5-1
Severity: normal
Tags: patch

Dear Maintainer,

When building a CD with the LB_DEBIAN_INSTALLER="live" option,
live-build will include a significant number of .deb packages that are
(as far as I can tell) not actually needed for installation.

The 'binary_debian-installer' script contains code designed to avoid
including the .deb files for packages that are already installed in
the live system.  However, the 'rm' command doesn't work due to
improper quoting.

I further noticed that the 'grep' command that is meant to force
certain packages (e.g. grub) to be included as .debs was also
not working as intended.

I believe the below patch fixes these issues:

--- scripts/build/binary_debian-installer.orig	2013-04-30
02:28:19.000000000 -0400
+++ scripts/build/binary_debian-installer	2014-02-21 16:20:37.000000000 -0500
@@ -528,11 +528,11 @@

 		# Drop the packages already installed that d-i doesn't explicitely need
 		_REMAINING_PACKAGES="$(echo ${DI_FIRMWARE_PACKAGES}
${DI_REQ_PACKAGES} | sed -e 's# #|#g')"
-		_REMAINING_PACKAGES="$(sed -n -e 's|Package: ||p'
chroot/var/lib/dpkg/status.tmp | grep -E -v
\"^${_REMAINING_PACKAGES}$\")"
+		_REMAINING_PACKAGES="$(sed -n -e 's|Package: ||p'
chroot/var/lib/dpkg/status.tmp | grep -E -v
"^(${_REMAINING_PACKAGES})\$")"

 		for _PACKAGE in ${_REMAINING_PACKAGES}
 		do
-			rm -f "chroot/binary.deb/archives/${_PACKAGE}_*.deb"
+			rm -f chroot/binary.deb/archives/${_PACKAGE}_*.deb
 		done
 	else
 		# Download .debs of the required packages

-- Package-specific info:

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-431.1.2.el6.x86_64 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages live-build depends on:
ii  debootstrap  1.0.48+deb7u1

Versions of packages live-build recommends:
ii  cpio                            2.11+dfsg-0.1
ii  gnu-fdisk                       1.2.4-3.1
ii  live-boot-doc                   3.0.1-1
ii  live-config-doc                 3.0.23-1
ii  live-manual-html [live-manual]  1:3.0.2-1

Versions of packages live-build suggests:
pn  debian-keyring          <none>
pn  dosfstools              <none>
pn  git                     <none>
ii  gpgv                    1.4.12-7+deb7u2
pn  loadlin                 <none>
pn  memtest86+ | memtest86  <none>
ii  mtools                  4.0.17-1
pn  parted                  <none>
ii  squashfs-tools          1:4.2-5
pn  sudo | fakeroot         <none>
ii  syslinux                2:4.05+dfsg-6+deb7u1
pn  uuid-runtime            <none>
pn  win32-loader            <none>
pn  xorriso                 <none>

-- no debconf information


Reply to: