[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697873: marked as done (live-boot: Easy fix for broken persistence-label parameter)

Your message dated Tue, 12 Feb 2013 07:32:31 +0000
with message-id <E1U5ALv-0000d9-1r@franck.debian.org>
and subject line Bug#697873: fixed in live-boot 3.0.0-1
has caused the Debian Bug report #697873,
regarding live-boot: Easy fix for broken persistence-label parameter
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
697873: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697873
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-boot
Version: 3.0~a35-1
Severity: important
Tags: patch

Dear Maintainer,

I have a persistent Live Wheezy 7.0~b4 working with the file name 'persistence'. If I use persistence-label=xyz and make a file named 'persistence-xyz' (with a proper live-persistence.conf file in it), then when the system is rebooted, the system will not be using either persistence file.

The porblem exists in live-boot 3.0~a35-1, 3.0~b4-1, and 3.0~b11-1

There is an easy fix. The problem is in cmdline.sh for 3.0~a and 9990-cmdline-old for 3.0~b. When the parameter is parsed, the label is applied to the variables without prefixes.

Current code:
	persistence-label=*)
		old_live_overlay_label="${_PARAMETER#persistence-label=*}"
		old_home_overlay_label="${_PARAMETER#persistence-label=*}"
		custom_overlay_label="${_PARAMETER#persistence-label=*}"
 		;;

Fixed code:
	persistence-label=*)
		old_live_overlay_label="live-rw-${_PARAMETER#persistence-label=*}"
		old_home_overlay_label="home-rw-${_PARAMETER#persistence-label=*}"
		custom_overlay_label="persistence-${_PARAMETER#persistence-label=*}"
		;;

I have tested this on 3.0~a35-1 and 3.0~b11-1 with keys that boot multiple images each with their own persistence file.

This is my first bug report. If I missed any information or need to do some specific testing, I would be happy to.

-- Package-specific info:

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages live-boot depends on:
ii  live-boot-initramfs-tools [live-boot-backend]  3.0~a35-1

Versions of packages live-boot recommends:
ii  eject          2.1.5+deb1+cvs20081104-11
ii  file           5.11-2
ii  live-boot-doc  3.0~a35-1
ii  rsync          3.0.9-3
ii  uuid-runtime   2.20.1-5.2

Versions of packages live-boot suggests:
pn  cryptsetup    <none>
pn  curlftpfs     <none>
pn  httpfs2       <none>
pn  unionfs-fuse  <none>
ii  wget          1.13.4-3

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: live-boot
Source-Version: 3.0.0-1

We believe that the bug you reported is fixed in the latest version of
live-boot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 697873@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <daniel@debian.org> (supplier of updated live-boot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 12 Feb 2013 08:23:17 +0100
Source: live-boot
Binary: live-boot live-boot-doc live-boot-initramfs-tools
Architecture: source all
Version: 3.0.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian Live Project <debian-live@lists.debian.org>
Changed-By: Daniel Baumann <daniel@debian.org>
Description: 
 live-boot  - Live System Boot Scripts
 live-boot-doc - Live System Boot Scripts (documentation)
 live-boot-initramfs-tools - Live System Boot Scripts (initramfs-tools backend)
Closes: 696494 696495 697873
Changes: 
 live-boot (3.0.0-1) unstable; urgency=low
 .
   [ Daniel Baumann ]
   * Updating manpage year handling for 2013.
 .
   [ Richard Nelson ]
   * Replace noprompt with noeject on manpage.
 .
   [ Daniel Baumann ]
   * Updating noeject description in manpage.
 .
   [ chals ]
   * Updating Spanish translation in respect to noeject.
 .
   [ Daniel Baumann ]
   * Dropping dpkg compression level.
   * Calling df with -P to avoid line wraps with overly long mountpoints.
 .
   [ Tails developers ]
   * Improving test for /etc/fstab.d support by testing for its existence
     instead of /run's one.
 .
   [ Daniel Baumann ]
   * Removing some dead code in netbase parts.
 .
   [ Gaudenz Steinlin ]
   * Fixing support for multiple squashfs images (Closes: #696494).
   * Fixing mounting of rootfs, cow and medium filesystems (Closes:
     #696495).
 .
   [ Daniel Baumann ]
   * Correcting persistence-label handling fwrt/ legacy live-boot 2.x
     support, thanks to Mike Gach <gach.mqt@gmail.com> (Closes: #697873).
Checksums-Sha1: 
 4b84d9ee3ccd6766f6e473bd09649925680ed44e 1369 live-boot_3.0.0-1.dsc
 18204a278c603005415dbcc93701421bc3deff74 58680 live-boot_3.0.0.orig.tar.xz
 b6f4422eaad02d9c41e265c9063466f5f8fb3d23 22336 live-boot_3.0.0-1.debian.tar.xz
 e9ff4053da5b1aba67a0f1d4e2705ea38912537f 48746 live-boot_3.0.0-1_all.deb
 372943dfba16ce1c99537d4816d1ae3b6eabf915 51726 live-boot-doc_3.0.0-1_all.deb
 f43e6e59f93a7e8d8b86b438fa0cb3c865f7a952 26280 live-boot-initramfs-tools_3.0.0-1_all.deb
Checksums-Sha256: 
 3fdb8f02bb3e5cce457af2e973922a1e9be6968c05f50d2e530c8d58088fd35b 1369 live-boot_3.0.0-1.dsc
 277b999f4fcd1511532479e21e8facbce2c288e1f3ed80bcf2cb54cec66615f0 58680 live-boot_3.0.0.orig.tar.xz
 868afb2615e4cfc471ec0ba574d963705d3a81ed0bbdf5fb5791416c70953db0 22336 live-boot_3.0.0-1.debian.tar.xz
 df253693957a1769dc48e477b745170d40999f3ce24261481d384778289a8387 48746 live-boot_3.0.0-1_all.deb
 58ee0163efe688a065392b1f6214f1359a48754325efc18b6d31a3433c4e05c0 51726 live-boot-doc_3.0.0-1_all.deb
 ca23c361bb08c886565c1daa3da4aac8f1f759bb7f6b828668b84a17b95be6fb 26280 live-boot-initramfs-tools_3.0.0-1_all.deb
Files: 
 61882150301dfe1137200d96d731de00 1369 misc optional live-boot_3.0.0-1.dsc
 a6859198d0782ca9c968b2f210eb9212 58680 misc optional live-boot_3.0.0.orig.tar.xz
 8fd7a18ad8e7c8ec5d80d4c03a98bc7d 22336 misc optional live-boot_3.0.0-1.debian.tar.xz
 9c1d72dcc5279a2a368ab0d84e40373e 48746 misc optional live-boot_3.0.0-1_all.deb
 13623fe33a1b96e291c8c244fa4a05bf 51726 doc optional live-boot-doc_3.0.0-1_all.deb
 dd630cd123e12348800670f97326c46d 26280 misc optional live-boot-initramfs-tools_3.0.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlEZ7tkACgkQ+C5cwEsrK566zwCfY/CoOcNqpe7n9TF3nxXwS6bc
qaEAoI3TfVvhGfo4wP47dr7Ykd32TaHA
=x8xo
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: