[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] fix problems with custom union mounts



04/29/2012 10:15 PM, Ian Geiser:
> Greetings, I ran into a problem when I was using the custom-ov
> approach with the union option.   It seems my version of busybox
> mount doesn't like it when there are two directory separators in a
> row.  So I added a small sed step to clean any duplicate separators
> that might be present.  I also found that when using the union
> approach that it did not get the correct rofs_dest_backing because
> the loop to configure those only was enabled for links.  I have
> attached a patch that addresses these two issues.  Thanks!
>
> [...]
> -    if [ -n "${opt_link}"]
> +    if [ -n "${opt_union}" ] || [ -n "${opt_link}" ]

Actually $rofs_dest_backing is completely unnecessary for $opt_link, but
you correctly have understood that it can be helpful for unions, so I
suggest the following change instead:

-    if [ -n "${opt_link}"]
+    if [ -n "${opt_union}" ]

Cheers!


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: