Re: [PATCH] fix unionfs-fuse support, remove is_nice_device cruft
On 03/29/2011 03:11 PM, David Kuehling wrote:
> You can pull the changes from git://github.com/dvdkhlng/live-boot.git
> commit: ebcce83a8cc72f567829.
thanks; sorry for the late answer, i'll merge it tomorrow.
> I also had a longer look at the evolution of the is_nice_device()
> function (which originated as is_usb_device() in casper). This looks
> like cruft, without any use nowadays. The commit log has a long comment
> why I think the removal was correct.
i'll check.
> And there is also 5f4fb42aca7c27b0729a that adds a smart comment that
> makes Emacs honour your indentation style (would you want to commit
> that?).
i'm very much in favour of not cluttering sources with any editor 'configs'.
> These are independent from the unionfs-fuse stuff, but I hope you merge
> them anyways.
apart from the emacs thing, i will. i'm too tired already now though,
i'll do it tomorrow when i'm 'fresh' again :)
> Now maybe next time I should split different commit groups into
> 'branches' or is there some other nice alternative to listing commit
> hashes?
usually, what people do is that they create one branch for one (group of
similar) fix(es). but i personally don't care much. if your stuff is
clear (rebased on top of current debian-next[0]), i don't care on what
brach the commits are and you can just ask for commits (or branches, if
you have more than one, or if the branch names are not self-explaining)
to be pulled.
[0] your commits appear to be ontop of debian, but that doesn't matter,
for now. in future, please always work ontop of debian-next branch.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@progress-technologies.net
Internet: http://people.progress-technologies.net/~daniel.baumann/
Reply to: