Re: /lib/udev/path_id no more exists in udev 174
Hi all!
I'm here again because of udev's built-in path_id. Actually, it's not about
this command itself, but about busybox's built-in sh shell.
The problem itself, in short terms, is that
exporting variable as command and then invoking that command
as "${VARIABLE}" in busybox's sh does not work. See below
root@kazsid:~# busybox sh
BusyBox v1.19.3 (Debian 1:1.19.3-4) built-in shell (ash)
Enter 'help' for a list of built-in commands.
~ # export PATH_ID="/sbin/udevadm test-builtin path_id"
~ # "${PATH_ID}"
sh: /sbin/udevadm test-builtin path_id: not found
~ # "$PATH_ID"
sh: /sbin/udevadm test-builtin path_id: not found
~ # ${PATH_ID}
syspath missing
As you can see, only third call worked, which is without double quotes ""
So please fix that,
On Thu, Nov 24, 2011 at 11:50 AM, Baurzhan Muftakhidinov
<baurthefirst@gmail.com> wrote:
> Hi all
>
> With the commit to live-boot Daniel missed the 'test-builtin' part of
> the command
> (http://live.debian.net/gitweb?p=live-boot.git;a=blobdiff;f=scripts/live;h=6bcfd86c3cb336761e45f41ac0d60c57b36ff928;hp=e69396e10cd8606f665dadbedeb78d805a942b08;hb=62e8bfc13fa085b9a5ccc5b77babbde618c4a553;hpb=dde97bb32a6c30e3329485d2d3e2b35539339b8d)
>
> It works like
>
> /sbin/udevadm test-builtin path_id /devices/platform/i8042/serio0/input/input0
> ID_PATH=platform-i8042-serio-0
> ID_PATH_TAG=platform-i8042-serio-0
>
> but not
>
> /sbin/udevadm path_id /devices/platform/i8042/serio0/input/input0
> missing or unknown command
>
> Usage: udevadm [--help] [--version] [--debug] COMMAND [COMMAND OPTIONS]
> info query sysfs or the udev database
> trigger request events from the kernel
> settle wait for the event queue to finish
> control control the udev daemon
> monitor listen to kernel and udev events
> test test an event run
> test-builtin test a built-in command
>
>
> Regards,
>
>
> ---------- Forwarded message ----------
> From: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
> Date: Mon, Nov 21, 2011 at 5:47 PM
> Subject: Re: /lib/udev/path_id no more exists in udev 174
> To: intrigeri <intrigeri+debian-live@boum.org>
> Cc: debian-live@lists.debian.org
>
>
> Well, I see that Daniel already fixed this.
>
> Cool!
>
> On Mon, Nov 21, 2011 at 5:38 PM, Baurzhan Muftakhidinov
> <baurthefirst@gmail.com> wrote:
>> Got it.
>> Please check it
>>
>> On Mon, Nov 21, 2011 at 5:17 PM, intrigeri
>> <intrigeri+debian-live@boum.org> wrote:
>>> Hi,
>>>
>>> Baurzhan Muftakhidinov wrote (21 Nov 2011 10:50:19 GMT) :
>>>> Added simple check for udev version, but not exactly the best coding
>>>> style ;)
>>>
>>> Checking if /lib/udev/path_id exists would be quite more robust than
>>> a version check, don't you think?
>>>
>>> Other than this, PATH_ID should be spelled in lowercase (consistency
>>> with all other "local" variables in functions), and probably called
>>> path_id_command for clarity's sake.
>>>
>>> (Yeah, it would not take that much time to fix it myself, but I'm
>>> happy helping you going the whole way to a patch that we can apply as
>>> is. This way, you'll know better what we expect next time.)
>>>
>>> Cheers,
>>> --
>>> intrigeri <intrigeri@boum.org>
>>> | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
>>> | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
>>> | Then we'll come from the shadows.
>>>
>>
Reply to: