[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#642463: marked as done (please support having parentheses in LB_ISO*)

Your message dated Tue, 27 Sep 2011 21:24:09 +0000
with message-id <E1R8f8L-0007bw-T5@franck.debian.org>
and subject line Bug#642463: fixed in live-build 3.0~a32-1
has caused the Debian Bug report #642463,
regarding please support having parentheses in LB_ISO*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

642463: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=642463
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: live-build
Version: 3.0_a31-1-12-gb820153
Severity: normal

in case those variables contain ( or ), see attached patch for the fix

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental'), (100, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
>From b820153c9cee6666d7875657a4ada04859cccaf1 Mon Sep 17 00:00:00 2001
From: Yaroslav Halchenko <debian@onerussian.com>
Date: Thu, 22 Sep 2011 15:02:32 -0400
Subject: [PATCH] ENH Enclose shell variables in "" (escaped) while evaluating
 for the length

Otherwise having () in the names would cause script to crash with

/usr/share/live/build/functions/defaults.sh: eval: line 1200: syntax error near unexpected token `(
 functions/defaults.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/functions/defaults.sh b/functions/defaults.sh
index 796724e..53c7af9 100755
--- a/functions/defaults.sh
+++ b/functions/defaults.sh
@@ -1218,22 +1218,22 @@ Check_defaults ()
-	if [ "$(echo ${LB_ISO_APPLICATION} | wc -c)" -gt 128 ]
+	if [ "$(echo \"${LB_ISO_APPLICATION}\" | wc -c)" -gt 128 ]
 		Echo_warning "You have specified a value of LB_ISO_APPLICATION that is too long; the maximum length is 128 characters."
-	if [ "$(echo ${LB_ISO_PREPARER} | wc -c)" -gt  128 ]
+	if [ "$(echo \"${LB_ISO_PREPARER}\" | wc -c)" -gt  128 ]
 		Echo_warning "You have specified a value of LB_ISO_PREPARER that is too long; the maximum length is 128 characters."
-	if [ "$(echo ${LB_ISO_PUBLISHER} | wc -c)" -gt 128 ]
+	if [ "$(echo \"${LB_ISO_PUBLISHER}\" | wc -c)" -gt 128 ]
 		Echo_warning "You have specified a value of LB_ISO_PUBLISHER that is too long; the maximum length is 128 characters."
-	if [ "$(eval "echo ${LB_ISO_VOLUME}" | wc -c)" -gt 32 ]
+	if [ "$(eval "echo \"${LB_ISO_VOLUME}\"" | wc -c)" -gt 32 ]
 		Echo_warning "You have specified a value of LB_ISO_VOLUME that is too long; the maximum length is 32 characters."

--- End Message ---
--- Begin Message ---
Source: live-build
Source-Version: 3.0~a32-1

We believe that the bug you reported is fixed in the latest version of
live-build, which is due to be installed in the Debian FTP archive:

  to main/l/live-build/live-build-cgi_3.0~a32-1_all.deb
  to main/l/live-build/live-build-cron_3.0~a32-1_all.deb
  to main/l/live-build/live-build_3.0~a32-1.debian.tar.gz
  to main/l/live-build/live-build_3.0~a32-1.dsc
  to main/l/live-build/live-build_3.0~a32-1_all.deb
  to main/l/live-build/live-build_3.0~a32.orig.tar.gz

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 642463@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Daniel Baumann <daniel@debian.org> (supplier of updated live-build package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Tue, 27 Sep 2011 22:54:36 +0200
Source: live-build
Binary: live-build live-build-cgi live-build-cron
Architecture: source all
Version: 3.0~a32-1
Distribution: unstable
Urgency: low
Maintainer: Debian Live Project <debian-live@lists.debian.org>
Changed-By: Daniel Baumann <daniel@debian.org>
 live-build - Debian Live - System Build Scripts
 live-build-cgi - Debian Live - System Build Scripts (cgi frontend)
 live-build-cron - Debian Live - System Build Scripts (cron autobuilder)
Closes: 642463
 live-build (3.0~a32-1) unstable; urgency=low
   [ Daniel Baumann ]
   * Correcting wrong spelling of cache in exit function, thanks to David
     Endler for spotting it.
   * Adding option for setting filesystem label on usb-hdd images.
   * Correcting syntax error in tr command used in default for hdd-label
     in progress mode.
   * Renaming usb-hdd binary image type to simply hdd.
   * Updating volatile handling in chroot_archives for derivatives when
     using foo-backports distribution scheme.
   * Temporarily removing live-tools from standard package list, doesn't
     work for derivatives yet.
   * Making sure that volatile for the parent distribution is still
     included in derivatives mode.
   * Switching away from cdn.debian.net as default mirrors for progress,
     too unreliable outside of Europe.
   * Renaming forgotten lb_binary_usb and lb_source_usb to lb_binary_hdd
     resp. lb_source_hdd.
   * Correcting incomplete checks for local packages in lb_binary_debian-
   * Removing leftovers from usb-hdd to hdd removal in lb_binary_hdd and
   [ Yaroslav Halchenko ]
   * Enclosing shell variables for iso-* defaults in escaped double-
     quotes while evaluating for the length to allow using parentheses
     (Closes: #642463).
   [ Daniel Baumann ]
   * Correcting typo in config/includes.chroot creating in lb_config,
     thanks to Stanislav Bogatyrev <realloc@realloc.spb.ru> for reporting
   [ Yaroslav Halchenko ]
   * Fixing left-over uses of --binary-indices in templates/cgi.
   * Fixing left-over uses of --packages-lists in cron scripts and
 5c6adc9d8451ee7bf7e468d375d43da9877a0511 1413 live-build_3.0~a32-1.dsc
 5d976d3dc4d52ad166355afc094c8ea1d534ac13 1839019 live-build_3.0~a32.orig.tar.gz
 b9cbfd9adba1434fb32e66c5d1f8831e917178d5 49213 live-build_3.0~a32-1.debian.tar.gz
 27b4bebca23b96a910ffc3f121ee7abc89b15413 1135756 live-build_3.0~a32-1_all.deb
 59e967a3693476a00cc4d7093b8b4e4a05ec582f 62626 live-build-cgi_3.0~a32-1_all.deb
 e41922ba2fd6033b5cb5cbdcb3972e8a9a4ce5cf 62692 live-build-cron_3.0~a32-1_all.deb
 78934b0fb7681393cce0828f4146ff58c53e9883cdb53db5726a402d0a092799 1413 live-build_3.0~a32-1.dsc
 d6aa0aff72c3bf4ddc8e810264bb49edf4068aa304904000bb70fd53435e3e95 1839019 live-build_3.0~a32.orig.tar.gz
 21c94436c20244d67d77bfdce01bf02c65cc0a719218ec91eaacf343a0d36e9d 49213 live-build_3.0~a32-1.debian.tar.gz
 029d766e4a0d3f7a63c82676c004cd810e9af66980753b11cc3ff5cf36699e23 1135756 live-build_3.0~a32-1_all.deb
 717b2e1ce890f2b04457cc9b569e2525365799913d3ac5f5ed641d4fbd7f687a 62626 live-build-cgi_3.0~a32-1_all.deb
 cd62af5e2bdca968c42541181b54a3018f5c9092651a33f9b416a4250b3fbd0b 62692 live-build-cron_3.0~a32-1_all.deb
 48259087ff5a1967b463482fe50fac64 1413 misc optional live-build_3.0~a32-1.dsc
 dec567c2ea683fa22e97554ff28a7d76 1839019 misc optional live-build_3.0~a32.orig.tar.gz
 25429e3f18cacca8537a6b8142f3def0 49213 misc optional live-build_3.0~a32-1.debian.tar.gz
 7a08041f1e13216356e4501397241d07 1135756 misc optional live-build_3.0~a32-1_all.deb
 25493dc91a795ed920f580e9d2658af0 62626 misc optional live-build-cgi_3.0~a32-1_all.deb
 4719769d162797ce4f6265ed10437054 62692 misc optional live-build-cron_3.0~a32-1_all.deb

Version: GnuPG v1.4.10 (GNU/Linux)


--- End Message ---

Reply to: