Bug#642396: live-config: In function Cmdline file existence is ignored during _SCRIPTS list construction.
retitle 642396 please don't fail if non-existing scripts are specified
severity 642396 wishlist
tag 642396 - patch
thanks
On 09/22/2011 09:48 AM, Stanislav Bogatyrev wrote:
> In function Cmdline file existence is ignored during _SCRIPTS list construction.
> This leaves live system in unconfigured state.
this is a purely cosmetical problem if a user specifies a script that
doesn't exist.
> Here is the patch to fix the issue.
since live-config is supposed to be optimized for speed, your patch is
suboptimal.
it introduces one if check for all _SCRIPTS that get assembled, one if
check for all _SCRIPTS that get removed. so, for those that actually get
removed, you introduce *two* if checks, and for those who actually get
run, you introduce one if check.
it's much simpler/faster/elegant to only check the resulting scripts in
the end, once, before sourcing them.
--
Address: Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email: daniel.baumann@progress-technologies.net
Internet: http://people.progress-technologies.net/~daniel.baumann/
Reply to: