[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#635046: live-build: Does not install config/chroot_packages/*.deb any more



Package: live-build
Version: 3.0~a25-1

Hello Daniel,

the experimental version merged the global/local package hooks and
config places into config/chroot_packages and corresponding scripts.

Since then, config/chroot_packages/*.deb does not actually get
installed any more.

lb_chroot_archives is correctly copying them to chroot/root/packages/
and creates the indexes, etc., but lb_chroot_install-packages only
installs the list in chroot/root/chroot_packages. The missing bit is
what lb_chroot_local-packages used to do, but that's not being called
any more in the experimental version.

A quick'n'dirty workaround is to add it back:

--- a/scripts/build/lb_chroot
+++ b/scripts/build/lb_chroot
@@ -50,6 +50,7 @@ lb chroot_resolv install ${*}
 lb chroot_hostname install ${*}
 lb chroot_apt install ${*}
 lb chroot_archives install ${*}
+lb chroot_local-packages ${*}

 # Customizing chroot
 lb chroot_linux-image ${*}

But that's of course not a proper patch for trunk, as (IIUC) trunk
wants to get rid of the _local stuff.

So I wonder where the creation of the chroot_packages list should
happen now? It seems to me as if it would be appropriate to do right
in lb_chroot_archives? It could create chroot_packages right after it
copies the debs to packages/ and creates the indexes. If it's
necessary/preferable to have as a separate step, should it be renamed
to lb_chroot_queue_packages or something like that?

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature


Reply to: