Re: [PATCH] [1/2] Do not attempt to recursively chown chroot or binary if LB_ROOT_COMMAND is set
On 07/21/2011 03:54 PM, Cody A.W. Somerville wrote:
> If the chroot filesystem type is plain then recursively chowning the
> binary directory will cause the same problems.
indeed, so we should guard that with a check for the binary filesystem.
like we just discussed in person a few minutes ago, i'll keep the calls
in binary stage (except adding the guard in one invocation where it's
necessary), and remove calls per your patch for chroot. as we said, this
will definitely break builds as non-root, but it was broken in other
ways before, so that doesn't really matter. we'll need to address
building with minimal root (and eventually building as non-root with
fakechroot) at some later point again.
--
Address: Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email: daniel.baumann@progress-technologies.net
Internet: http://people.progress-technologies.net/~daniel.baumann/
Reply to: