On Wed, Jul 20, 2011 at 2:43 AM, Daniel Baumann
<daniel.baumann@progress-technologies.net> wrote:
On 07/19/2011 09:29 PM, Cody A.W. Somerville wrote:
> Please accept this patch which updates the lb_binary_usb
> helper to modify the flags with a properly configured loop mount as well
> as apply the fix that caused the regression to lb_source_usb (but
> without the problem fixed here of course).
the things on lb_binary_usb make perfectly sense, thanks for that.
however, your things on lb_source_usb do not, setting the lba flag
already is operated on the image at no offset.
Sorry if I was not clear. The changes to lb_source_usb are not to fix a corruption issue but to fix the original bug that was being fixed in the commit that introduced the regression as the original fix was only applied to lb_binary_usb. Naturally, my patch to fix the original bug for lb_source_usb avoids the pitfall/regression my patch fixes in lb_binary_usb. :)
Cheers,