Bug#588306: live-initramfs: Unreachable code in do_netmount

[Marco Amadori <amadorim@vdavda.com>]

In data mercoledì 7 luglio 2010 10:49:06, Colin Watson ha scritto:

> do_netmount is called in exactly one place:
> 
>         if [ ! -z "${NETBOOT}" ] || [ ! -z "${FETCH}" ] || [ ! -z
> "${HTTPFS}" ] || [ ! -z "${FTPFS}" ] then
>                 if do_netmount
> 
> That function then contains code guarded by this conditional:
> 
>         if [ -z "${NETBOOT}" ] && [ -z "${FETCH}" ] && \
>            [ -z "${HTTPFS}" ] && [ -z "${FTPFS}" ]
>         then

It is "do_netsetup" that contains that code, not "do_netmount", so the rest of 
"do_netsetup" will be executed.

It seems to me that this bug should be tagged invalid for that reason.

> That code can therefore never be called.  When is it supposed to be run?

That code seems to be added when the networking of live-initramfs leveraged 
the initramfs-tools one.

It is quite a time since I didn't personally tested that netboot (cifs or nfs) 
code, did you found that it currently do not work? If that is the case please 
open a new bug report and I'll do a regression test/fix cycle.

-- 
ESC:wq

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.