[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#588306: marked as done (unreachable code in do_netmount)

Your message dated Thu, 02 Sep 2010 10:53:35 +0200
with message-id <4C7F660F.4020600@debian.org>
and subject line Re: unreachable code in do_netmount
has caused the Debian Bug report #588306,
regarding unreachable code in do_netmount
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
588306: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588306
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-initramfs
Version: 1.236.2-1
Severity: normal
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu maverick

do_netmount is called in exactly one place:

        if [ ! -z "${NETBOOT}" ] || [ ! -z "${FETCH}" ] || [ ! -z "${HTTPFS}" ] || [ ! -z "${FTPFS}" ]
        then
                if do_netmount

That function then contains code guarded by this conditional:

        if [ -z "${NETBOOT}" ] && [ -z "${FETCH}" ] && \
           [ -z "${HTTPFS}" ] && [ -z "${FTPFS}" ]
        then

That code can therefore never be called.  When is it supposed to be run?

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
you're claiming that do_netmount() contains the guard, but that's not
true (it does stuff before a guard which is run for all netboot
variants, and then contains a guard that is tighter than all netboot
variants to do stuff only needed for those specific netboot variants),
so no dead code (though, it's dead ugly :), however, closing this bug.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

--- End Message ---
Reply to: