Re: live-config [patch]: fails to configure xserver-xorg in Lenny images
intrigeri wrote (10 Aug 2010 10:25:59 GMT) :
> as I explained on IRC: Lenny's dexconf wants every
> xserver-xorg/config/inputdevice/keyboard/* setting to be configured as
> soon as one is. Else it aborts and XOrg ends up unconfigured.
> The following patch workaround this by reverting to use
> dpkg-reconfigure instead of dexconf on Lenny.
The attached follow-up patch fixes this for real: grep returns
non-zero exit status if no match is found, which made this script to
error out and prevented later scripts to be run.
Bye,
--
intrigeri <intrigeri@boum.org>
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr-fingerprint.asc
| If you must label the absolute, use it's proper name: Temporary.
>From a5976485710e2b2e49f161cb9ccbde527506d512 Mon Sep 17 00:00:00 2001
From: amnesia <amnesia@boum.org>
Date: Tue, 10 Aug 2010 12:44:04 +0200
Subject: [PATCH 3/3] Ignoring grep return status.
---
scripts/config/116-xserver-xorg | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/scripts/config/116-xserver-xorg b/scripts/config/116-xserver-xorg
index 8985e6c..bd99178 100755
--- a/scripts/config/116-xserver-xorg
+++ b/scripts/config/116-xserver-xorg
@@ -81,7 +81,8 @@ Configure_xserver_xorg ()
dpkg-reconfigure -f noninteractive -p critical \
xserver-xorg 2>&1 \
| grep -v "overwriting possibly-customised configuration" \
- | grep -v "file; backup in /etc/X11/xorg.conf"
+ | grep -v "file; backup in /etc/X11/xorg.conf" \
+ || :
else
dexconf
fi
--
1.7.1
Reply to: