Re: [PATCH] Don't download packages for on-disk archive that are already installed into the chroot
On 05/20/2010 06:44 AM, Cody A.W. Somerville wrote:
> Please accept this patch which updates the binary_local-packageslists
> helper to not download and install packages into the on-disk archive if
> they're already installed in the chroot (aka livefs).
this was done on purpose because the live filesystem is one thing, and
the installer (which takes its packages out of the pool on the image in
non-live mode) is another, indepentent one.
however, in the case where we use live-installer to have d-i not using
the pool to install the system, but the filesystem instead, not
doublicating the packages is a very reasonable thing to do.
since using live-installer per se doesn't mean we're not going to use
the non-live installer, it would be bad to make it the default (and thus
loosing the flexibility to have two boot menu entries for d-i, one with
live-installer, and one without)
still, making your patch only enabled by default when using live
installer isn't so good either i guess, since
This is
> accomplished by using a copy of chroot/var/lib/dpkg/status instead of
> temporarily using a new, blank chroot/var/lib/dpkg/status.
>
> The rationale for this change is that specifying a single package to be
> installed into the on-disk archive can result in hundreds of megabytes
> of packages being downloaded and put in the image. This is because
> binary_local-packageslists uses apt to fetch the packages and since
> currently a blank chroot/var/lib/dpkg/status is used, apt will download
> all sorts of packages to meet package dependencies. With the common use
> case for including packages in the on-disk archive being able to install
> packages after installation or during a live session without having to
> access a remote debian archive, including tons of packages that won't
> even get touched is a huge waste of time and dramatically inflates the
> size of the image.
>
> Thus, the main benefits of this change is that images taking advantage
> of this feature will be substantially smaller and won't take as long to
> build.
>
> Cheers,
>
> --
> Cody A.W. Somerville
> Release Engineer
> Foundations Team
> Custom Engineering Solutions Group
> Canonical OEM Services
> Phone: +1 781 850 2087
> Cell: +1 613 401 5141
> Fax: +1 613 687 7368
> Email: cody.somerville@canonical.com <mailto:cody.somerville@canonical.com>
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: