[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#570162: marked as done (live-initramfs: persistent-path parameter does not work for snapshot files)



Your message dated Sun, 14 Mar 2010 22:47:40 +0000
with message-id <E1Nqway-00062h-95@ries.debian.org>
and subject line Bug#570162: fixed in live-initramfs 1.173.5-1
has caused the Debian Bug report #570162,
regarding live-initramfs: persistent-path parameter does not work for snapshot files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
570162: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570162
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: live-initramfs
Version: 1.173.1-1
Severity: normal
Tags: patch

Hello,

I seems that the parameter persistent-path does not work for finding snapshot files.
Indeed, it is stored in the variable PERSISTENT_PATH, that is only used in the function
find_cow_device. But, for finding snapshot files, it is the function find_files that
is used.

Here is a raw, untested patch that should enable it.

Regards,

-- 
Tanguy Ortolo

-- System Information:
Debian Release: 5.0.4
  APT prefers stable
  APT policy: (990, 'stable'), (60, 'testing'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages live-initramfs depends on:
ii  busybox                       1:1.10.2-2 Tiny utilities for small and embed
ii  file                          4.26-1     Determines file type using "magic"
ii  initramfs-tools               0.93.4     tools for generating an initramfs
ii  sudo                          1.6.9p17-2 Provide limited super user privile
ii  udev                          150-2      /dev/ and hotplug management daemo
pn  user-setup                    <none>     (no description available)

Versions of packages live-initramfs recommends:
ii  eject                    2.1.5+deb1-4    ejects CDs and operates CD-Changer
ii  uuid-runtime             1.41.3-1        universally unique id library
ii  wget                     1.11.4-2+lenny1 retrieves files from the web

Versions of packages live-initramfs suggests:
pn  curlftpfs                     <none>     (no description available)
pn  genext2fs                     <none>     (no description available)
pn  httpfs2                       <none>     (no description available)
pn  loop-aes-utils                <none>     (no description available)
pn  mtd-tools                     <none>     (no description available)
ii  squashfs-tools                1:3.3-7    Tool to create and append to squas
--- scripts/live.old	2010-02-16 15:54:51.686141553 +0100
+++ scripts/live	2010-02-16 15:56:01.056530161 +0100
@@ -991,7 +991,7 @@
 	if [ "${PERSISTENT}" != "nofiles" ]
 	then
 		# search for image files
-		snapdata=$(find_files "${snap_label}.squashfs ${snap_label}.cpio.gz ${snap_label}.ext2 ${snap_label}.ext3 ${snap_label}.ext4 ${snap_label}.jffs2")
+		snapdata=$(find_files "${PERSISTENT_PATH}${snap_label}.squashfs ${PERSISTENT_PATH}${snap_label}.cpio.gz ${PERSISTENT_PATH}${snap_label}.ext2 ${PERSISTENT_PATH}${snap_label}.ext3 ${PERSISTENT_PATH}${snap_label}.ext4 ${PERSISTENT_PATH}${snap_label}.jffs2")
 	fi
 
 	if [ -z "${snapdata}" ]

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: live-initramfs
Source-Version: 1.173.5-1

We believe that the bug you reported is fixed in the latest version of
live-initramfs, which is due to be installed in the Debian FTP archive:

live-initramfs_1.173.5-1.diff.gz
  to main/l/live-initramfs/live-initramfs_1.173.5-1.diff.gz
live-initramfs_1.173.5-1.dsc
  to main/l/live-initramfs/live-initramfs_1.173.5-1.dsc
live-initramfs_1.173.5-1_all.deb
  to main/l/live-initramfs/live-initramfs_1.173.5-1_all.deb
live-initramfs_1.173.5.orig.tar.gz
  to main/l/live-initramfs/live-initramfs_1.173.5.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 570162@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <daniel@debian.org> (supplier of updated live-initramfs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Mar 2010 23:27:57 +0100
Source: live-initramfs
Binary: live-initramfs
Architecture: source all
Version: 1.173.5-1
Distribution: unstable
Urgency: low
Maintainer: Debian Live <debian-live@lists.debian.org>
Changed-By: Daniel Baumann <daniel@debian.org>
Description: 
 live-initramfs - Debian Live initramfs hook
Closes: 521129 545842 570100 570162
Changes: 
 live-initramfs (1.173.5-1) unstable; urgency=low
 .
   [ Daniel Baumann ]
   * Updating contact information in copyright file.
   * Simplyfing initramfs triggers (Closes: #521129, #545842).
   * Wrapping fields in control file.
   * Using minimized rules file.
   * Simplifying wording in bug-presubj file.
 .
   [ Andreas Teuchert ]
   * Calling udevadm settle in scripts/init-premount/select_eth_device
     (Closes: #570100).
 .
   [ Tanguy Ortolo ]
   * Also respecting persistent-path parameter for snapshots (Closes:
     #570162).
Checksums-Sha1: 
 d488d4d00413166b680ea868b4dcc2ec7d68f8bf 1300 live-initramfs_1.173.5-1.dsc
 24f0c0060a1c6dc89fde44121e2b355d9d1b27d6 87863 live-initramfs_1.173.5.orig.tar.gz
 7f1c9e57a2e293b5c4e7ea323ded084182517f46 32548 live-initramfs_1.173.5-1.diff.gz
 cd57bfb9b31af90e506d9ca1441a80611cdfd2f5 100002 live-initramfs_1.173.5-1_all.deb
Checksums-Sha256: 
 de91bb85373dcd6cec559dfe1cbba6ae152e6cf1c930c2db49abf112d4427e84 1300 live-initramfs_1.173.5-1.dsc
 3ddd19d843f4990e64becd0208e8285fb5fd89baba1a5bf79ec8f0342ef6844a 87863 live-initramfs_1.173.5.orig.tar.gz
 03f27c8caec0dbf54d2ace623823a1412f84170f0b28ce99abf5423f618380b2 32548 live-initramfs_1.173.5-1.diff.gz
 0a97deb015484049854414700cfa7e773be97f34f14ec32e740927901724fd0e 100002 live-initramfs_1.173.5-1_all.deb
Files: 
 58f39935471678ee1db0d30d453c98c0 1300 misc optional live-initramfs_1.173.5-1.dsc
 1972b815457e9e81790092ac30313bb9 87863 misc optional live-initramfs_1.173.5.orig.tar.gz
 8009dca5f1125e72465f91857f86bd40 32548 misc optional live-initramfs_1.173.5-1.diff.gz
 cb7f4263ceed2fef359b12baca9ada12 100002 misc optional live-initramfs_1.173.5-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkudY3EACgkQ+C5cwEsrK56MxgCdGGGF8hlGmgLVtx9SGIdTLQL4
UXAAoJ0QV4uL3/P2tGtXcJGfwK7VMZxa
=LWFl
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: