[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#570330: binary_syslinux and binary_grub assume LH_BINARY_IMAGES is singular.



Package: live-helper
Version: 2.0~a7-1
Severity: normal

With --binary-images 'iso usb-hdd', the case dispatch of
"${LH_BINARY_IMAGES}" at

    /usr/share/live-helper/helpers/binary_syslinux:365

fails to match, resulting in line 407 of the same file

    mkdir -p "${KERNEL_PATH}"

attempting to mkdir the empty string.

Maybe --binary-images only supports a single image type at a time?  If
so, this behaviour isn't a bug.  I expected it to support "iso
usb-hdd" only because it's a plural (*images*, not image).

PS: I'd have isolated the problem faster if live-helper's case
dispatches had a fallback clause along the lines of

    *) if test -n "$DEBUGGING_IS_ON"
       then echo >&2 "<magic hash>: Execution probably shouldn't reach this point."
       fi;;

...where <magic hash> is a different short string in each case.  Then,
when seeing the problem in lh build --debug, I could have simply
grepped for that magic hash.

Better than a magic hash would be "${BASH_SOURCE[0]}:$LINENO", but
it's a bashism.

-- Package-specific info:

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-xen-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages live-helper depends on:
ii  cdebootstrap                  0.5.5      Bootstrap a Debian system
ii  debootstrap                   1.0.20     Bootstrap a basic Debian system

Versions of packages live-helper recommends:
ii  gettext-base                  0.17-9     GNU Internationalization utilities

Versions of packages live-helper suggests:
ii  dosfstools                 3.0.9-1       utilities for making and checking 
ii  fakeroot                   1.14.4-1      Gives a fake root environment
ii  genext2fs                  1.4.1-2.2     ext2 filesystem generator for embe
ii  genisoimage                9:1.1.10-1    Creates ISO-9660 CD-ROM filesystem
ii  memtest86+                 4.00-2.2      thorough real-mode memory tester
ii  mtd-utils [mtd-tools]      20090606-1    Memory Technology Device Utilities
ii  mtools                     4.0.12-1      Tools for manipulating MSDOS files
pn  parted                     <none>        (no description available)
ii  squashfs-tools             1:4.0-6       Tool to create and append to squas
ii  sudo                       1.7.2p1-1     Provide limited super user privile
ii  syslinux                   2:3.83+dfsg-3 utilities for the syslinux bootloa
ii  uuid-runtime               2.16.2-0      runtime components for the Univers
pn  win32-loader               <none>        (no description available)

-- no debconf information



Reply to: