[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#518463: [Pkg-sysvinit-devel] Bug#518463: initscripts: skip live specific file systems



On Friday 06 March 2009 21:08:24 Daniel Baumann wrote:
> Package: initscripts
> Severity: wishlist
> Tags: patch
> Owner: debian-live@lists.debian.org
>
> Hi,
>
> /etc/init.d/umountfs unmounts both temporary and local filesystems.
> however, in case of a live system, trying to unmount /cow, /live* or
> /filesystem* will not work and therefore results in an (end-user
> confusing) warning, that the respective fs could not have been unmounted
> because it's busy.
>
> In the latest version of live-initramfs we do workaround this at runtime
> by patching the script. However, it would be nice if this could be
> improved and integrated into the umountfs script itself.
>
> Note that the namespace (/live*, /filesystem* etc.) is stable, it is
> already part of some excluding/including mechanisms in gnome-vfs and
> live-installer. so you don't have to fear that even if you hardcode it,
> that you don't need to change it soon again. However, if you would
> prefere something with an exclude mechanism by sourcing from another
> file that would be only there on live-systems, that's fine too. Please
> let me know what you'd prefere.
>
> Anyway, here is what we do currently:
>
> sed -i -e 's#pioodl $TMPFS_MTPTS)#pioodl $TMPFS_MTPTS | sed -e "s@\\
> @\\n@" | grep -v ^/live)#' \
> -e 's#pioodl $REG_MTPTS)#pioodl $REG_MTPTS | sed -e "s@\\ @\\n@"
> | grep -v ^/live | grep -v ^/filesystem) /#' \
> /etc/init.d/umountfs


How about something like:
---
--- debian/initscripts/etc/init.d/umountfs (revision 1331)
+++ debian/initscripts/etc/init.d/umountfs (working copy)
@@ -79,6 +79,10 @@
continue
fi
;;
+ /filesystem*|/live*)
+ # used by live-initramfs
+ continue
+ ;;
esac
case "$FSTYPE" in
proc|procfs|linprocfs|devfs|sysfs|usbfs|usbdevfs|devpts)
---


>
> in the second replace, we also add '/' so that $REG_MTPTS is never
> empty. it would be nice if you can make the whole unmounting of local
> filesystems conditional, so that the script doesn't try to do anything
> when there's nothing to unmount.


I do not know why adding / to REG_MTPTS helps. What is the rationale for it?


Thanks, Kel.


Reply to: