[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#522382: live-initramfs: using 'persistent=nofiles' parameter [PATCH]



On Wednesday 29 July 2009, 12:16:54, Daniel Baumann wrote:

> Rui Miguel Bernardo wrote:
> > Here is a correct patch (I hope).
>
> for the records (it doesn't matter here, but it's a major nuissance in
> general when sending patches): your diff is somewhat cluttered, you
> should only change what you changed on purpose and thus send a minimal
> diff only (e.g. here, the case statement is changed without changing it
> (probably changed the indenting)).
>
> anyway, Marco, can you comment on the 'break' one?

My mistake, this is the correct minimal patch (I'll git it in my repo too):

diff --git a/scripts/live-helpers b/scripts/live-helpers
index 35fb8cf..978aa06 100644
--- a/scripts/live-helpers
+++ b/scripts/live-helpers
@@ -367,7 +367,7 @@ find_cow_device ()
 			then
 				# do not mount the device to find for image files
 				# just skip this
-				break
+				continue
 			fi
 
 			case "$(get_fstype ${devname})" in


-- 
ESC:wq

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.


Reply to: