[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] fixed parameter passing via live.vars in 21xdriver



Ronny Standtke wrote:
>>> Passing parameters to 21xdriver via live.vars (esp. XDRIVER) is broken.
>> it's not broken, it's deliberately not sourced in order to optimize for
>> speed.

first of all, don't cc me. rumours has it that i'll read the list from
time to time.

> How am I supposed to hand over XDRIVER from a previous script to 21xdriver 
> from now on?

set xdriver= to something and set XDRIVER to something in live.vars.

> Small reminder: You added sourcing of live.vars to 21xdriver 
> exactly for this (good) reason.

you're mixing up sourcing live.vars in any case, or conditionally
sourcing live.vars.

while i agree that conditionally sourcing isn't the best way to do it,
in particular because it should only once sources before run-parts, that
is not something that's going to be changed anytime soon (until
live-initramfs 2.x), and in the meanwhile it's not a good idea
performance wise to get yet another penalty in the default use case
which is neither using live.vars nor xdriver.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/


Reply to: