[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Add support for lpia arch



Cody A.W. Somerville wrote:
> Refreshed the patch and made recommended changes.

diff --git a/functions/defaults.sh b/functions/defaults.sh
index 06e1478..c358ddb 100755
--- a/functions/defaults.sh
+++ b/functions/defaults.sh
@@ -518,6 +518,19 @@ Set_defaults ()
 				LH_LINUX_FLAVOURS="itanium"
 				;;

+			lpia)
+				case "${LH_MODE}" in
+					debian|debian-release|embedian)
+						Echo_error "Architecture ${LH_ARCHITECTURE} not supported on
${LH_MODE}."
+						exit 1

the idea is to fail not immediately, but after the whole config has been
done. that's better for the user. i'll leave it out here and change this
in a leter commit (same in later occurencies).

diff --git a/helpers/lh_binary_linux-image b/helpers/lh_binary_linux-image
index f5abaab..0b1c542 100755
--- a/helpers/lh_binary_linux-image
+++ b/helpers/lh_binary_linux-image
@@ -53,19 +53,11 @@ case "${LH_INITRAMFS}" in
 esac

 case "${LH_ARCHITECTURE}" in
-	amd64)
-		LINUX="vmlinuz"
-		;;
-
-	i386)
-		LINUX="vmlinuz"
-		;;
-
 	powerpc)
 		LINUX="vmlinux"
 		;;

-	sparc)
+	*)
 		LINUX="vmlinuz"
 		;;
 esac

but you saw that on powerpc, it's vmlinux not vmlinuz?

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/


Reply to: