Bug#469085: live-helper: md5sum can't handle all filenames

[wijnen at debian.org (Bas Wijnen)]

Package: live-helper
Version: 1.0~a38-1
Tags: patch

When including files in the binary image which have strange characters
in them (I think even spaces, but certainly quotes), lh_binary_md5sum
chokes due to xargs parsing those characters.  The problematic line is

	find . -type f | sort | grep -v 'isolinux/isolinux.bin' | grep
	-v 'boot/grub/stage2_eltorito' | xargs -I{} md5sum "{}" >
	../md5sum.txt

The error message (when having files with quotes) suggests using the -0
option.  This is a good idea, but needs '\0'-separated fields.  So the
line becomes:

	find . -type f | sort | grep -v 'isolinux/isolinux.bin' | grep
	-v 'boot/grub/stage2_eltorito' | while read file ; do echo -en
	"$file\0" ; done | xargs -0 -I{} md5sum "{}" > ../md5sum.txt

I'm not entirely sure if there're bashisms in there, but I don't think
so.  I tested this (with bash) and it can indeed handle files with
spaces and quotes in their names.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/debian-live-devel/attachments/20080303/70902c3e/attachment.pgp