[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#490290: marked as done (live-helper: Could handle empty LH_LINUX_PACKAGES more gracefully)

Your message dated Thu, 11 Sep 2008 08:27:24 +0200
with message-id <48C8BA4C.5040709@debian.org>
and subject line Re: live-helper: Could handle empty LH_LINUX_PACKAGES more gracefully
has caused the Debian Bug report #490290,
regarding live-helper: Could handle empty LH_LINUX_PACKAGES more gracefully
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
490290: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490290
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-helper
Version: 1.0~a47-1
Severity: minor

Hi,

currently, if one tries and sets LH_LINUX_PACKAGES to the empty string,
it ends up with the following:
| P: Being installing packages...
| [apt output]
| E: Regex compilation error - Invalid preceding regular expression

I first tried to workaround this with the attached patch, but it looks
the “offending” code is rather in functions/defaults.sh, under “# Set
linux packages”, since the following ends up in the package list:
| [chroot/root/chroot_packages]
| linux-image-2.6-486
| ${LH_UNION_FILESYSTEM}-modules-2.6-486
| # and much more

Looks like we're back to an interpolation problem. ;-)

Cheers,

--
Cyril Brulebois

>From 373f6e1e94c81475f313b92c2b38bc7bc2b6aa91 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <cyril.brulebois@kerlabs.com>
Date: Fri, 11 Jul 2008 11:54:04 +0200
Subject: [PATCH] Try and fix LH_LINUX_PACKAGES gracefully.

---
 helpers/lh_chroot_linux-image |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/helpers/lh_chroot_linux-image b/helpers/lh_chroot_linux-image
index 56f4da4..cb71bbd 100755
--- a/helpers/lh_chroot_linux-image
+++ b/helpers/lh_chroot_linux-image
@@ -63,6 +63,12 @@ EOF
 		#	mv chroot/usr/sbin/update-initramfs chroot/usr/sbin/update-initramfs.live-helper
 		#fi
 
+		if [ -z "${LH_LINUX_PACKAGES}" ]
+		then
+			Echo_message "LH_LINUX_PACKAGES is empty, assuming 'none' was meant."
+			LH_LINUX_PACKAGES="none"
+		fi
+
 		if [ "${LH_LINUX_PACKAGES}" != "none" ]
 		then
 			for FLAVOUR in ${LH_LINUX_FLAVOURS}
-- 
1.5.6

--- End Message ---
--- Begin Message --- 
I'm closing this bug then; you're welcome to reopen with evidence of the
actual bug.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

--- End Message ---
Reply to: