[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

No subject



> @@ -239,7 +271,22 @@
>  			rm -rf chroot/var/lib/apt/lists
>  			mkdir -p chroot/var/lib/apt/lists/partial
>  
> -			echo "deb ${LH_MIRROR_BINARY} ${LH_DISTRIBUTION} ${LH_SECTIONS}" > chroot/etc/apt/sources.list
> +			# Remove first if exists
> +            rm -f chroot/etc/apt/sources.list

Wrong indentation

> diff -Naur live-helper-new-clean/usr/bin/lh_config live-helper-new-to-commit/usr/bin/lh_config
> --- live-helper-new-clean/usr/bin/lh_config	2008-04-28 18:18:28.000000000 +0200
> +++ live-helper-new-to-commit/usr/bin/lh_config	2008-05-20 20:33:20.446951988 +0200
> @@ -112,6 +112,7 @@
>  \t    [--union-filesystem aufs|unionfs]\n\
>  \t    [--exposed-root enabled|disabled]\n\
>  \t    [--username NAME]\n\
> +\t    [--processors NUMBER]\n\
>  \t    [--verbose]"
>  
>  Local_arguments ()
> @@ -582,6 +583,12 @@
>  				shift 2
>  				;;
>  
> +			--processors)
> +				# Warning: the usage of more than 1 processor for squashfs FS creation, not seems to be pretty stable, better to use it just for tests when fast builds are needed
> +				LH_PROCESSORS="${2}"
> +				shift 2
> +				;;
> +

I'm sorry but I fail to reconize that it's true. I use squashfs
creating in a quad-code machine, daily, and it works fine.

I've opted to give this a first review so your broke-up patch series
will be near of merging.

Thanks by all the work.

Cheers,

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



Reply to: