[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

LH_BINARY_IMAGES was: Rescue flavor improvements

2008/4/28 Tzafrir Cohen <tzafrir.cohen at xorcom.com>:
> On Mon, Apr 28, 2008 at 11:09:37AM +0100, Alex Owen wrote:
>  > >  The obvious example is  LH_BINARY_IMAGES,which can contain permutations of
>  > >  "iso", "usb-hdd" and "net".
>  >
>  > So if I find a place in the code where LH_BINARY_IMAGES is expected to
>  > be single valued (ie not a list of image types) then that is a bug?
>  This is just a theoretical question, right?

I'm not certain that the 'case "${LH_BINARY_IMAGES}" in' stanzas will
always do the right thing if LH_BINARY_IMAGES is a sapce seperated
list of image types!

Also code like this:
 if [ ${LH_BINARY_IMAGES} = "iso" ] || [ ${LH_BINARY_IMAGES} = "usb-hdd" ]

$cat /etc/debian_version
$ dpkg -l live-helper
| Status=Not/Installed/Config-files/Unpacked/Failed-config/Half-installed
|/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad)
||/ Name                             Version
ii  live-helper                      1.0~a45-1
Debian Live build scripts

$grep LH_BINARY_IMAGES /usr/bin/lh* | grep case
/usr/bin/lh_binary_debian-installer:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_debian-installer:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_grub:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_grub:case ${LH_BINARY_IMAGES} in
/usr/bin/lh_binary_syslinux:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_syslinux:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_yaboot:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_binary_yaboot:case "${LH_BINARY_IMAGES}" in
/usr/bin/lh_chroot_hacks:case "${LH_BINARY_IMAGES}" in

Reply to: