Bug#461595: live-initramfs: live-snapshot script is broken (like argument handling)

[mika at grml.org (Michael Prokop)]

Package: live-initramfs
Version: 1.110.7-1
Severity: important


live-snapshot does not work as documented:

# live-snapshot -d /dev/sdb1
live-snapshot: option requires an argument -- d
Terminating.

# live-snapshot
ln: creating symbolic link `/home/grml/Desktop/live-snapshot' to `/mnt/live-snapshot': No such file or directory
# ls -la /mnt/live-snapshot
total 36344
drwxrwxrwt  2 root root       60 2008-01-19 18:48 ./
drwxr-xr-x 18 root root      380 2008-01-19 18:44 ../
-rw-r--r--  1 root root 37171774 2008-01-19 18:48 live-sn.cpio.gz

I'm not sure how:

        ARGS="${1}"
        ARGUMENTS="$(getopt --longoptions cow:,device:,output,resync-string:,type:,help,usage,version --name=${PROGRAM} --options c:d:o:t:r:,h,u,v --shell sh -- ${ARGS})"

should work at all. Changing that into:

        ARGS="$*"
        [...]

seems to fix at least the option parsing issue.

And the:

                if [ ! -L /home/${USERNAME}/Desktop/live-snapshot ]
                then
                        ln -s "${MOUNTP}" /home/${USERNAME}/Desktop/live-snapshot
                fi

should include a check whether /home/${USERNAME}/Desktop exists at
all.

Is anyone using live-snapshot at all? :) It should receive some work
+ updates - like providing some usage examples in the manpage. I'm
not even sure how to re-use the generated live-sn.cpio.gz file when
rebooting my live-system. I'd work on those issues and will provide
patches, but would welcome some basic instructions about the
supposed workflow of live-snapshot before re-enventing the wheel. ;)

regards,
-mika-