[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)



On Mon, Nov 12, 2007 at 10:55:09PM +0100, Daniel Baumann wrote:
> Trent W. Buck wrote:
> > I wonder if it would be simpler to
> > change all the shebangs to #/bin/bash?
> 
> Why restricting to bash when it's not required to do that? If it would
> be of much use to e.g. use arrays, I'd go for bash only, but currently,
> we could do everything without relaying on bash-only features.

On the subject of bashisms, here are some hits in the current Sid version:

$ checkbashisms `grep -rl '#!/bin/sh' live-helper-1.0~a34/ live-initramfs-1.110.5/ `
possible bashism in live-helper-1.0~a34/functions/help.sh line 21 (echo -e):
                echo -e "${USAGE}"
possible bashism in live-helper-1.0~a34/functions/breakpoints.sh line 17 (read without variable):
                read
possible bashism in live-helper-1.0~a34/helpers/lh_binary_usb-hdd line 160 (read without variable):
        echo "WAITING..." && read
possible bashism in live-initramfs-1.110.5/bin/live-snapshot line 86 (echo -e):
                echo -e "${MESSAGE}"
possible bashism in live-initramfs-1.110.5/bin/live-snapshot line 104 (echo -e):
    echo -e "\nLook at live-snapshot(1) man page for more information."

Probably these should be "read dontcare" and "/bin/echo -e".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/debian-live-devel/attachments/20071113/56101a87/attachment.pgp 


Reply to: